Sustainable Kibana Architecture: Move modules owned by `@elastic/observability-ui` #202834

gsoldevila · 2024-12-03T22:51:29Z

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Any manual contributions will be lost if the 'relocate' script is re-run.
Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

1 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/observability-shared-plugin`	`x-pack/solutions/observability/plugins/observability_shared`

3 packages(s) are going to be relocated:

Id	Target folder
`@kbn/observability-utils-browser`	`x-pack/solutions/observability/packages/utils_browser`
`@kbn/observability-utils-common`	`x-pack/solutions/observability/packages/utils_common`
`@kbn/observability-utils-server`	`x-pack/solutions/observability/packages/utils_server`

Updated references

./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/dev/storybook/aliases.ts
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/.i18nrc.json
./x-pack/solutions/observability/packages/utils_browser/jest.config.js
./x-pack/solutions/observability/packages/utils_common/jest.config.js
./x-pack/solutions/observability/packages/utils_server/jest.config.js
./x-pack/solutions/observability/plugins/observability_shared/jest.config.js
./x-pack/test/tsconfig.type_check.json
./yarn.lock
.github/CODEOWNERS

Updated relative paths

x-pack/solutions/observability/packages/utils_browser/jest.config.js:10
x-pack/solutions/observability/packages/utils_browser/tsconfig.json:2
x-pack/solutions/observability/packages/utils_common/jest.config.js:10
x-pack/solutions/observability/packages/utils_common/tsconfig.json:2
x-pack/solutions/observability/packages/utils_server/jest.config.js:10
x-pack/solutions/observability/packages/utils_server/tsconfig.json:2
x-pack/solutions/observability/plugins/observability_shared/jest.config.js:10
x-pack/solutions/observability/plugins/observability_shared/tsconfig.json:12
x-pack/solutions/observability/plugins/observability_shared/tsconfig.json:2
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:102
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:105
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:108
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:111
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:114
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:14
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:2
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:21
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:24
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:27
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:30
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:33
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:36
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:39
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:42
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:45
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:48
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:51
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:54
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:57
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:60
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:63
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:66
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:69
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:72
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:75
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:78
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:81
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:84
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:87
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:90
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:93
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:96
x-pack/solutions/observability/plugins/observability_shared/tsconfig.type_check.json:99

github-actions · 2024-12-03T22:51:41Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2024-12-04T08:31:07Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2024-12-04T08:31:08Z

Pinging @elastic/unified-observability (Team:Unified observability)

shahzad31 · 2024-12-04T08:58:24Z

x-pack/solutions/observability/packages/observability/observability_utils/observability_utils_browser

i find it weird that word observability is used 4 times in this dir structure

weltenwort · 2024-12-04T11:54:51Z

💭 this might cause conflicts with open PRs that change observability_shared, such as #201263, which tries to clean up dependencies

github-actions · 2024-12-10T14:36:11Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

afharo

Core changes LGTM

gsoldevila · 2024-12-23T13:42:15Z

i find it weird that word observability is used 4 times in this dir structure

I simplified the target folder structure (see updated PR description).

…-fix'

elasticmachine · 2024-12-24T16:05:08Z

💚 Build Succeeded

Buildkite Build
Commit: d6d7e84
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202834-d6d7e84cd4df

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityShared`	93.9KB	93.9KB	-1.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`observabilityShared`	14	13	-1

Total ESLint disabled count

id	before	after	diff
`observabilityShared`	15	14	-1

History

💚 Build #262841 succeeded 0eb283c
💔 Build #262775 failed a4224ca
💔 Build #262023 failed f70c6b7
💔 Build #261481 failed f7ef92d
💔 Build #258789 failed 0ab8693

gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Unified observability labels Dec 4, 2024

gsoldevila marked this pull request as ready for review December 4, 2024 08:31

gsoldevila requested review from a team as code owners December 4, 2024 08:31

gsoldevila force-pushed the kbn-team-1309-move-kibana-observability-ui branch from e0fd1ac to 21a0527 Compare December 10, 2024 14:35

botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 10, 2024

Ikuni17 approved these changes Dec 11, 2024

View reviewed changes

crespocarlos self-requested a review December 16, 2024 15:46

gsoldevila force-pushed the kbn-team-1309-move-kibana-observability-ui branch from 0ab8693 to fe143a1 Compare December 17, 2024 15:46

afharo approved these changes Dec 17, 2024

View reviewed changes

rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024

crespocarlos approved these changes Dec 18, 2024

View reviewed changes

dokmic force-pushed the kbn-team-1309-move-kibana-observability-ui branch from f7ef92d to f70c6b7 Compare December 18, 2024 19:43

gsoldevila force-pushed the kbn-team-1309-move-kibana-observability-ui branch from f70c6b7 to e8fac5a Compare December 23, 2024 13:21

gsoldevila added 3 commits December 23, 2024 17:33

Relocating module @kbn/observability-shared-plugin

c35aacd

Relocating module @kbn/observability-utils-browser

75e82c9

Relocating module @kbn/observability-utils-common

bfb3907

gsoldevila and others added 3 commits December 23, 2024 17:33

Relocating module @kbn/observability-utils-server

ad4d5a5

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

23d51b4

…-fix'

Fix styled_components_files

0eb283c

gsoldevila force-pushed the kbn-team-1309-move-kibana-observability-ui branch from e40e88f to 0eb283c Compare December 23, 2024 16:33

Dosant approved these changes Dec 23, 2024

View reviewed changes

gsoldevila added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 23, 2024

gsoldevila and others added 2 commits December 24, 2024 15:58

Merge branch 'main' into kbn-team-1309-move-kibana-observability-ui

4f18677

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

d6d7e84

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move modules owned by `@elastic/observability-ui` #202834

Sustainable Kibana Architecture: Move modules owned by `@elastic/observability-ui` #202834

gsoldevila commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

shahzad31 commented Dec 4, 2024

weltenwort commented Dec 4, 2024

github-actions bot commented Dec 10, 2024

afharo left a comment

gsoldevila commented Dec 23, 2024

elasticmachine commented Dec 24, 2024 •

edited

Loading

ESLint disabled line counts

Total ESLint disabled count

Sustainable Kibana Architecture: Move modules owned by @elastic/observability-ui #202834

Are you sure you want to change the base?

Sustainable Kibana Architecture: Move modules owned by @elastic/observability-ui #202834

Conversation

gsoldevila commented Dec 3, 2024 • edited Loading

Summary

1 plugin(s) are going to be relocated:

3 packages(s) are going to be relocated:

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

shahzad31 commented Dec 4, 2024

weltenwort commented Dec 4, 2024

github-actions bot commented Dec 10, 2024

🤖 GitHub comments

afharo left a comment

Choose a reason for hiding this comment

gsoldevila commented Dec 23, 2024

elasticmachine commented Dec 24, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Sustainable Kibana Architecture: Move modules owned by `@elastic/observability-ui` #202834

Sustainable Kibana Architecture: Move modules owned by `@elastic/observability-ui` #202834

gsoldevila commented Dec 3, 2024 •

edited

Loading

elasticmachine commented Dec 24, 2024 •

edited

Loading