Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/observability-ui #202834

Merged
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -765,9 +765,6 @@ x-pack/packages/kbn-alerting-state-types @elastic/response-ops
x-pack/packages/kbn-random-sampling @elastic/kibana-visualizations
x-pack/packages/kbn-synthetics-private-location @elastic/obs-ux-management-team
x-pack/packages/maps/vector_tile_utils @elastic/kibana-presentation
x-pack/packages/observability/observability_utils/observability_utils_browser @elastic/observability-ui
x-pack/packages/observability/observability_utils/observability_utils_common @elastic/observability-ui
x-pack/packages/observability/observability_utils/observability_utils_server @elastic/observability-ui
x-pack/packages/search/shared_ui @elastic/search-kibana
x-pack/packages/security/api_key_management @elastic/kibana-security
x-pack/packages/security/authorization_core @elastic/kibana-security
Expand Down Expand Up @@ -908,7 +905,6 @@ x-pack/plugins/observability_solution/apm/ftr_e2e @elastic/obs-ux-infra_services
x-pack/plugins/observability_solution/inventory @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/inventory/e2e @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/metrics_data_access @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/observability_shared @elastic/observability-ui
x-pack/plugins/observability_solution/profiling @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/profiling_data_access @elastic/obs-ux-infra_services-team
x-pack/plugins/reporting @elastic/appex-sharedux
Expand Down Expand Up @@ -940,6 +936,9 @@ x-pack/solutions/observability/packages/kbn-investigation-shared @elastic/obs-ux
x-pack/solutions/observability/packages/observability_ai/observability_ai_common @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/observability_ai/observability_ai_server @elastic/obs-ai-assistant
x-pack/solutions/observability/packages/synthetics_test_data @elastic/obs-ux-management-team
x-pack/solutions/observability/packages/utils_browser @elastic/observability-ui
x-pack/solutions/observability/packages/utils_common @elastic/observability-ui
x-pack/solutions/observability/packages/utils_server @elastic/observability-ui
x-pack/solutions/observability/plugins/exploratory_view @elastic/obs-ux-management-team
x-pack/solutions/observability/plugins/infra @elastic/obs-ux-logs-team @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/investigate @elastic/obs-ux-management-team
Expand All @@ -951,6 +950,7 @@ x-pack/solutions/observability/plugins/observability_ai_assistant_management @el
x-pack/solutions/observability/plugins/observability_logs_explorer @elastic/obs-ux-logs-team
x-pack/solutions/observability/plugins/observability_onboarding @elastic/obs-ux-logs-team
x-pack/solutions/observability/plugins/observability_onboarding/e2e @elastic/obs-ux-logs-team
x-pack/solutions/observability/plugins/observability_shared @elastic/observability-ui
x-pack/solutions/observability/plugins/observability_solution/entities_data_access @elastic/obs-entities
x-pack/solutions/observability/plugins/observability_solution/entity_manager_app @elastic/obs-entities
x-pack/solutions/observability/plugins/serverless_observability @elastic/obs-ux-management-team
Expand Down Expand Up @@ -1445,7 +1445,7 @@ packages/kbn-monaco/src/esql @elastic/kibana-esql
/x-pack/test_serverless/**/test_suites/observability/config.ts @elastic/observability-ui

# Observability onboarding tour
/x-pack/plugins/observability_solution/observability_shared/public/components/tour @elastic/appex-sharedux
/x-pack/solutions/observability/plugins/observability_shared/public/components/tour @elastic/appex-sharedux
/x-pack/test/functional/apps/infra/tour.ts @elastic/appex-sharedux

# Observability settings
Expand Down Expand Up @@ -2576,7 +2576,7 @@ x-pack/platform/plugins/private/translations/translations
x-pack/test/profiling_api_integration @elastic/obs-ux-infra_services-team

# Observability shared profiling
x-pack/plugins/observability_solution/observability_shared/public/components/profiling @elastic/obs-ux-infra_services-team
x-pack/solutions/observability/plugins/observability_shared/public/components/profiling @elastic/obs-ux-infra_services-team

# Shared UX
/x-pack/test_serverless/api_integration/test_suites/common/favorites @elastic/appex-sharedux # Assigned per https://github.com/elastic/kibana/pull/200985
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ Elastic.
|This plugin provides an onboarding framework for observability solutions: Logs and APM.


|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/observability_shared/README.md[observabilityShared]
|{kib-repo}blob/{branch}/x-pack/solutions/observability/plugins/observability_shared/README.md[observabilityShared]
|A plugin that contains components and utilities shared by all Observability plugins.


Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -705,11 +705,11 @@
"@kbn/observability-logs-overview": "link:x-pack/platform/packages/shared/observability/logs_overview",
"@kbn/observability-onboarding-plugin": "link:x-pack/solutions/observability/plugins/observability_onboarding",
"@kbn/observability-plugin": "link:x-pack/solutions/observability/plugins/observability",
"@kbn/observability-shared-plugin": "link:x-pack/plugins/observability_solution/observability_shared",
"@kbn/observability-shared-plugin": "link:x-pack/solutions/observability/plugins/observability_shared",
"@kbn/observability-synthetics-test-data": "link:x-pack/solutions/observability/packages/synthetics_test_data",
"@kbn/observability-utils-browser": "link:x-pack/packages/observability/observability_utils/observability_utils_browser",
"@kbn/observability-utils-common": "link:x-pack/packages/observability/observability_utils/observability_utils_common",
"@kbn/observability-utils-server": "link:x-pack/packages/observability/observability_utils/observability_utils_server",
"@kbn/observability-utils-browser": "link:x-pack/solutions/observability/packages/utils_browser",
"@kbn/observability-utils-common": "link:x-pack/solutions/observability/packages/utils_common",
"@kbn/observability-utils-server": "link:x-pack/solutions/observability/packages/utils_server",
"@kbn/oidc-provider-plugin": "link:x-pack/test/security_api_integration/plugins/oidc_provider",
"@kbn/open-telemetry-instrumented-plugin": "link:test/common/plugins/otel_metrics",
"@kbn/openapi-common": "link:src/platform/packages/shared/kbn-openapi-common",
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-babel-preset/styled_components_files.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ module.exports = {
/src[\/\\]plugins[\/\\]kibana_react[\/\\]/,
/x-pack[\/\\]platform[\/\\]packages[\/\\]shared[\/\\]kbn-elastic-assistant[\/\\]/,
/x-pack[\/\\]plugins[\/\\]fleet[\/\\]/,
/x-pack[\/\\]plugins[\/\\]observability_solution[\/\\]observability_shared[\/\\]/,
/x-pack[\/\\]plugins[\/\\]security_solution[\/\\]/,
/x-pack[\/\\]solutions[\/\\]observability[\/\\]plugins[\/\\]observability_shared[\/\\]/,
/x-pack[\/\\]solutions[\/\\]observability[\/\\]plugins[\/\\]exploratory_view[\/\\]/,
/x-pack[\/\\]solutions[\/\\]observability[\/\\]plugins[\/\\]observability[\/\\]/,
/x-pack[\/\\]solutions[\/\\]observability[\/\\]plugins[\/\\]synthetics[\/\\]/,
Expand Down
2 changes: 1 addition & 1 deletion src/dev/storybook/aliases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const storybookAliases = {
observability_ai_assistant_app:
'x-pack/solutions/observability/plugins/observability_ai_assistant_app/.storybook',
observability_inventory: 'x-pack/plugins/observability_solution/inventory/.storybook',
observability_shared: 'x-pack/plugins/observability_solution/observability_shared/.storybook',
observability_shared: 'x-pack/solutions/observability/plugins/observability_shared/.storybook',
observability_slo: 'x-pack/solutions/observability/plugins/slo/.storybook',
presentation: 'src/plugins/presentation_util/storybook',
random_sampling: 'x-pack/packages/kbn-random-sampling/.storybook',
Expand Down
16 changes: 8 additions & 8 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -1346,16 +1346,16 @@
"@kbn/observability-onboarding-plugin/*": ["x-pack/solutions/observability/plugins/observability_onboarding/*"],
"@kbn/observability-plugin": ["x-pack/solutions/observability/plugins/observability"],
"@kbn/observability-plugin/*": ["x-pack/solutions/observability/plugins/observability/*"],
"@kbn/observability-shared-plugin": ["x-pack/plugins/observability_solution/observability_shared"],
"@kbn/observability-shared-plugin/*": ["x-pack/plugins/observability_solution/observability_shared/*"],
"@kbn/observability-shared-plugin": ["x-pack/solutions/observability/plugins/observability_shared"],
"@kbn/observability-shared-plugin/*": ["x-pack/solutions/observability/plugins/observability_shared/*"],
"@kbn/observability-synthetics-test-data": ["x-pack/solutions/observability/packages/synthetics_test_data"],
"@kbn/observability-synthetics-test-data/*": ["x-pack/solutions/observability/packages/synthetics_test_data/*"],
"@kbn/observability-utils-browser": ["x-pack/packages/observability/observability_utils/observability_utils_browser"],
"@kbn/observability-utils-browser/*": ["x-pack/packages/observability/observability_utils/observability_utils_browser/*"],
"@kbn/observability-utils-common": ["x-pack/packages/observability/observability_utils/observability_utils_common"],
"@kbn/observability-utils-common/*": ["x-pack/packages/observability/observability_utils/observability_utils_common/*"],
"@kbn/observability-utils-server": ["x-pack/packages/observability/observability_utils/observability_utils_server"],
"@kbn/observability-utils-server/*": ["x-pack/packages/observability/observability_utils/observability_utils_server/*"],
"@kbn/observability-utils-browser": ["x-pack/solutions/observability/packages/utils_browser"],
"@kbn/observability-utils-browser/*": ["x-pack/solutions/observability/packages/utils_browser/*"],
"@kbn/observability-utils-common": ["x-pack/solutions/observability/packages/utils_common"],
"@kbn/observability-utils-common/*": ["x-pack/solutions/observability/packages/utils_common/*"],
"@kbn/observability-utils-server": ["x-pack/solutions/observability/packages/utils_server"],
"@kbn/observability-utils-server/*": ["x-pack/solutions/observability/packages/utils_server/*"],
"@kbn/oidc-provider-plugin": ["x-pack/test/security_api_integration/plugins/oidc_provider"],
"@kbn/oidc-provider-plugin/*": ["x-pack/test/security_api_integration/plugins/oidc_provider/*"],
"@kbn/open-telemetry-instrumented-plugin": ["test/common/plugins/otel_metrics"],
Expand Down
2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"xpack.observabilityAiAssistantManagement": "solutions/observability/plugins/observability_ai_assistant_management",
"xpack.observabilityLogsExplorer": "solutions/observability/plugins/observability_logs_explorer",
"xpack.observability_onboarding": "solutions/observability/plugins/observability_onboarding",
"xpack.observabilityShared": "plugins/observability_solution/observability_shared",
"xpack.observabilityShared": "solutions/observability/plugins/observability_shared",
"xpack.observabilityLogsOverview": [
"platform/packages/shared/observability/logs_overview/src/components"
],
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/packages/observability/observability_utils/observability_utils_common'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils_browser'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/packages/observability/observability_utils/observability_utils_server'],
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils_common'],
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,5 @@
module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: [
'<rootDir>/x-pack/packages/observability/observability_utils/observability_utils_browser',
],
roots: ['<rootDir>/x-pack/solutions/observability/packages/utils_server'],
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

module.exports = {
preset: '@kbn/test',
rootDir: '../../../../..',
roots: ['<rootDir>/x-pack/solutions/observability/plugins/observability_shared'],
setupFiles: [
'<rootDir>/x-pack/solutions/observability/plugins/observability_shared/.storybook/jest_setup.js',
],
coverageDirectory:
'<rootDir>/target/kibana-coverage/jest/x-pack/solutions/observability/plugins/observability_shared',
coverageReporters: ['text', 'html'],
collectCoverageFrom: [
'<rootDir>/x-pack/solutions/observability/plugins/observability_shared/{common,public,server}/**/*.{js,ts,tsx}',
],
};
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ export const useEsSearch = <DocumentSource extends unknown, TParams extends esty
});
});
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [...fnDeps]);

const { rawResponse } = response as any;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../../tsconfig.base.json",
"extends": "../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types"
},
Expand All @@ -9,7 +9,7 @@
"public/**/*.json",
"server/**/*",
"typings/**/*",
"../../../../typings/**/*",
"../../../../../typings/**/*",
".storybook/**/*"
],
"kbn_references": [
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6509,23 +6509,23 @@
version "0.0.0"
uid ""

"@kbn/observability-shared-plugin@link:x-pack/plugins/observability_solution/observability_shared":
"@kbn/observability-shared-plugin@link:x-pack/solutions/observability/plugins/observability_shared":
version "0.0.0"
uid ""

"@kbn/observability-synthetics-test-data@link:x-pack/solutions/observability/packages/synthetics_test_data":
version "0.0.0"
uid ""

"@kbn/observability-utils-browser@link:x-pack/packages/observability/observability_utils/observability_utils_browser":
"@kbn/observability-utils-browser@link:x-pack/solutions/observability/packages/utils_browser":
version "0.0.0"
uid ""

"@kbn/observability-utils-common@link:x-pack/packages/observability/observability_utils/observability_utils_common":
"@kbn/observability-utils-common@link:x-pack/solutions/observability/packages/utils_common":
version "0.0.0"
uid ""

"@kbn/observability-utils-server@link:x-pack/packages/observability/observability_utils/observability_utils_server":
"@kbn/observability-utils-server@link:x-pack/solutions/observability/packages/utils_server":
version "0.0.0"
uid ""

Expand Down