-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated EnablementModalCallout name to AdditionalChargesMessage #203061
Conversation
…prove clarity and readability, along with all references to that component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
# Conflicts: # x-pack/plugins/security_solution_serverless/public/components/additional_charges_message/additional_charges_message.tsx # x-pack/plugins/security_solution_serverless/public/components/additional_charges_message/index.tsx # x-pack/plugins/security_solution_serverless/public/components/additional_charges_message/lazy.tsx # x-pack/plugins/security_solution_serverless/public/components/enablement_modal_callout/enablement_modal_callout.tsx # x-pack/plugins/security_solution_serverless/public/components/enablement_modal_callout/index.tsx # x-pack/plugins/security_solution_serverless/public/components/enablement_modal_callout/lazy.tsx # x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/enablement_modal_callout.tsx # x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/index.tsx # x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/lazy.tsx
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @CAWilson94 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…tic#203061) ## Summary This PR renames the enablementModalCallout component to AdditionalChargesMessage for better clarity and alignment with its purpose, addressing [this comment](elastic#201920 (review)) from the original PR. ### Before and After (the output has not changed) ![image](https://github.com/user-attachments/assets/c07ac4a4-51db-4d5c-9040-3cde4fbd199e) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Mark Hopkin <[email protected]>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
This PR renames the enablementModalCallout component to AdditionalChargesMessage for better clarity and alignment with its purpose, addressing this comment from the original PR.
Before and After (the output has not changed)
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.