Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated EnablementModalCallout name to AdditionalChargesMessage #203061

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Updated EnablementModalCallout name to AdditionalChargesMessage #203061

merged 2 commits into from
Dec 19, 2024
+16 −16

Conversation

CAWilson94
Copy link
Contributor

@CAWilson94 CAWilson94 commented Dec 5, 2024 •
edited by kibanamachine
Loading

Summary

This PR renames the enablementModalCallout component to AdditionalChargesMessage for better clarity and alignment with its purpose, addressing this comment from the original PR.

Before and After (the output has not changed)

image

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@CAWilson94
Updated EnablementModalCallout name to AdditionalChargesMessage to im…
e4d0e48 
…prove clarity and readability, along with all references to that component.
@CAWilson94 CAWilson94 requested review from a team as code owners December 5, 2024 09:47
@CAWilson94 CAWilson94 requested a review from hop-dev December 5, 2024 09:47
hop-dev
hop-dev approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀

@CAWilson94 CAWilson94 self-assigned this Dec 5, 2024
@CAWilson94 CAWilson94 added release_note:enhancement v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Entity Analytics Security Entity Analytics Team backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Dec 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@hop-dev
Merge branch 'main' into additional-charges-message
4bf060f 
# Conflicts:
#	x-pack/plugins/security_solution_serverless/public/components/additional_charges_message/additional_charges_message.tsx
#	x-pack/plugins/security_solution_serverless/public/components/additional_charges_message/index.tsx
#	x-pack/plugins/security_solution_serverless/public/components/additional_charges_message/lazy.tsx
#	x-pack/plugins/security_solution_serverless/public/components/enablement_modal_callout/enablement_modal_callout.tsx
#	x-pack/plugins/security_solution_serverless/public/components/enablement_modal_callout/index.tsx
#	x-pack/plugins/security_solution_serverless/public/components/enablement_modal_callout/lazy.tsx
#	x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/enablement_modal_callout.tsx
#	x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/index.tsx
#	x-pack/solutions/security/plugins/security_solution_serverless/public/components/enablement_modal_callout/lazy.tsx
@hop-dev hop-dev enabled auto-merge (squash) December 19, 2024 12:56
@hop-dev hop-dev removed the v8.17.0 label Dec 19, 2024
@hop-dev hop-dev merged commit a21fb6c into elastic:main Dec 19, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12414895524

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #60 / dashboard app - group 3 dashboard panel copy to "after all" hook for "it always appends new panels instead of overwriting"
  • [job] [logs] FTR Configs #60 / dashboard app - group 3 dashboard panel copy to copies a panel to an existing dashboard

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.4MB 21.4MB +2.0B
securitySolutionServerless 133.2KB 133.2KB +2.0B
total +4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 26.4KB 26.4KB +2.0B

History

cc @CAWilson94

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 203061

Questions ?

Please refer to the Backport tool documentation

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@CAWilson94 @hop-dev @JoseLuisGJ
Updated EnablementModalCallout name to AdditionalChargesMessage (elas…
8d2f31a 
…tic#203061)

## Summary
This PR renames the enablementModalCallout component to
AdditionalChargesMessage for better clarity and alignment with its
purpose, addressing [this
comment](elastic#201920 (review))
from the original PR.

### Before and After (the output has not changed) 


![image](https://github.com/user-attachments/assets/c07ac4a4-51db-4d5c-9040-3cde4fbd199e)

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Mark Hopkin <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 23, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203061 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203061 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203061 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hop-dev hop-dev hop-dev approved these changes

Assignees

@CAWilson94 CAWilson94

Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:enhancement Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CAWilson94 @elasticmachine @kibanamachine @hop-dev