Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823) #205046

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…t package with prebuilt rules (elastic#204823)

**Fixes: elastic#204812

## Summary

This PR increases the total timeout for installing the prebuilt rules
package from the API integration tests from 2 minutes to 6 minutes,
where 6 minutes = 2 minutes * 3 attempts.

Logic before the fix:
- If the first attempt takes more than 2 minutes, it will continue to
run.
- If the first attempt takes less than 2 minutes, there will be a second
one.
- If the first attempt takes more than 2 minutes, there won't be a
second one.

Logic after the fix:
- If the first attempt takes more than 2 minutes, it will continue to
run.
- If the first attempt takes less than 2 minutes, there will be a second
one.
- If the first attempt takes more than 2 minutes but less than 6, there
will be a second one.
- If the first attempt takes more than 6 minutes, there won't be a
second one.

Context:
elastic#204812 (comment)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 39091fc)
@kibanamachine kibanamachine merged commit 68c891a into elastic:8.16 Dec 20, 2024
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / EQL Tab rendering it renders the timeline column headers

Metrics [docs]

✅ unchanged

cc @banderror

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants