Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823) #205046

Merged
merged 1 commit into from
Dec 20, 2024
+6 −6
Merged

[8.16] [Security Solution] Reduce flakiness in functions for installing Fleet package with prebuilt rules (#204823) #205046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...est_suites/detections_response/utils/rules/prebuilt_rules/install_fleet_package_by_url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import expect from 'expect';
import { refreshSavedObjectIndices } from '../../refresh_index';

const MAX_RETRIES = 2;
const ATTEMPT_TIMEOUT = 120000;
const TOTAL_TIMEOUT = 6 * 60000; // 6 mins, applies to all attempts (1 + MAX_RETRIES)

/**
* Installs latest available non-prerelease prebuilt rules package `security_detection_engine`.
Expand Down Expand Up @@ -46,7 +46,7 @@ export const installPrebuiltRulesPackageViaFleetAPI = async (
},
{
retryCount: MAX_RETRIES,
timeout: ATTEMPT_TIMEOUT,
timeout: TOTAL_TIMEOUT,
}
);

Expand Down Expand Up @@ -87,7 +87,7 @@ export const installPrebuiltRulesPackageByVersion = async (
},
{
retryCount: MAX_RETRIES,
timeout: ATTEMPT_TIMEOUT,
timeout: TOTAL_TIMEOUT,
}
);

Expand Down
6 changes: 3 additions & 3 deletions ...es/detections_response/utils/rules/prebuilt_rules/install_prebuilt_rules_fleet_package.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import expect from 'expect';
import { refreshSavedObjectIndices } from '../../refresh_index';

const MAX_RETRIES = 2;
const ATTEMPT_TIMEOUT = 120000;
const TOTAL_TIMEOUT = 6 * 60000; // 6 mins, applies to all attempts (1 + MAX_RETRIES)

/**
* Installs the `security_detection_engine` package via fleet API. This will
Expand Down Expand Up @@ -60,7 +60,7 @@ export const installPrebuiltRulesFleetPackage = async ({
},
{
retryCount: MAX_RETRIES,
timeout: ATTEMPT_TIMEOUT,
timeout: TOTAL_TIMEOUT,
}
);

Expand Down Expand Up @@ -94,7 +94,7 @@ export const installPrebuiltRulesFleetPackage = async ({
},
{
retryCount: MAX_RETRIES,
timeout: ATTEMPT_TIMEOUT,
timeout: TOTAL_TIMEOUT,
}
);

Expand Down
Loading