Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Reporting/Discover/Search Sessions] Only use relative time filter when generating share data (#112588) #112736

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…en generating share data (elastic#112588)

* only use relative time filter when generating share data

* Added comment on absolute time filter.

Co-authored-by: Tim Sullivan <[email protected]>

* improve discover search session relative time range test

* update discover tests and types for passing in data plugin to getSharingData function

* updated reporting to pass in data plugin to getSharingData, also updates jest tests

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Tim Sullivan <[email protected]>
Co-authored-by: Anton Dosov <[email protected]>
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 583.0KB 583.3KB +247.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 68.1KB 68.3KB +166.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jloleysens

@kibanamachine kibanamachine merged commit 1e82d05 into elastic:7.x Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants