[Reporting] Fix screenshot diagnostics #116199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
reporting/fix-115107-screenshot-diagnostics
branch
from
268b1d3 to
0650585
Compare
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
added
the
release_note:skip
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Oct 26, 2021
x-pack/plugins/reporting/server/lib/layouts/preserve_layout.test.ts
Outdated
Show resolved
Hide resolved
| it('preserve layout allows customizable selectors', () => { | ||
| const testPreserveLayout = new PreserveLayout( | ||
| { width: 16, height: 16 }, | ||
| { renderComplete: '[great-test-selectors]' } |
There was a problem hiding this comment.
@tsullivan always has "great" test inputs 😄
…07-screenshot-diagnostics
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Oct 26, 2021
* [Reporting] Fix screenshot diagnostics * update snapshots * fix test * tersify test assertions Co-authored-by: Kibana Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
Oct 26, 2021
* [Reporting] Fix screenshot diagnostics * update snapshots * fix test * tersify test assertions Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #115107
The issue is that the diagnostics tool uses a customized "selectors dictionary" for capturing the screenshot of the home page. Using a custom selector dictionary broke in #109010
Checklist
Delete any items that are not applicable to this PR.