Remove dashboard embeddable #194892
Merged
Remove dashboard embeddable #194892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
Bamieh
approved these changes
Dec 10, 2024
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
|
@elasticmachine merge upstream |
|
ignoring request to update branch, pull request is closed |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
Closes elastic#197281 PR replaces `DashboardContainer`, which implements legacy Container and Embeddable interfaces, with plain old javascript object implementation returned from `getDashboardApi`. The following are out of scope for this PR and will be accomplished at a later time: 1) re-factoring dashboard folder structure 2) removing all uses of Embeddable and EmbeddableInput types 3) removing legacy types like DashboardContainerInput --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Hannah Mudge <[email protected]> Co-authored-by: Devon Thomson <[email protected]> (cherry picked from commit 101e797)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Remove dashboard embeddable (#194892)](#194892) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:34:04Z","message":"Remove dashboard embeddable (#194892)\n\nCloses https://github.com/elastic/kibana/issues/197281\r\n\r\nPR replaces `DashboardContainer`, which implements legacy Container and\r\nEmbeddable interfaces, with plain old javascript object implementation\r\nreturned from `getDashboardApi`.\r\n\r\nThe following are out of scope for this PR and will be accomplished at a\r\nlater time:\r\n1) re-factoring dashboard folder structure\r\n2) removing all uses of Embeddable and EmbeddableInput types\r\n3) removing legacy types like DashboardContainerInput\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Hannah Mudge <[email protected]>\r\nCo-authored-by: Devon Thomson <[email protected]>","sha":"101e797e9dc0f2d0c08f89f9dbe36cd30812ee01","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"Remove dashboard embeddable","number":194892,"url":"https://github.com/elastic/kibana/pull/194892","mergeCommit":{"message":"Remove dashboard embeddable (#194892)\n\nCloses https://github.com/elastic/kibana/issues/197281\r\n\r\nPR replaces `DashboardContainer`, which implements legacy Container and\r\nEmbeddable interfaces, with plain old javascript object implementation\r\nreturned from `getDashboardApi`.\r\n\r\nThe following are out of scope for this PR and will be accomplished at a\r\nlater time:\r\n1) re-factoring dashboard folder structure\r\n2) removing all uses of Embeddable and EmbeddableInput types\r\n3) removing legacy types like DashboardContainerInput\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Hannah Mudge <[email protected]>\r\nCo-authored-by: Devon Thomson <[email protected]>","sha":"101e797e9dc0f2d0c08f89f9dbe36cd30812ee01"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194892","number":194892,"mergeCommit":{"message":"Remove dashboard embeddable (#194892)\n\nCloses https://github.com/elastic/kibana/issues/197281\r\n\r\nPR replaces `DashboardContainer`, which implements legacy Container and\r\nEmbeddable interfaces, with plain old javascript object implementation\r\nreturned from `getDashboardApi`.\r\n\r\nThe following are out of scope for this PR and will be accomplished at a\r\nlater time:\r\n1) re-factoring dashboard folder structure\r\n2) removing all uses of Embeddable and EmbeddableInput types\r\n3) removing legacy types like DashboardContainerInput\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Hannah Mudge <[email protected]>\r\nCo-authored-by: Devon Thomson <[email protected]>","sha":"101e797e9dc0f2d0c08f89f9dbe36cd30812ee01"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Closes elastic#197281 PR replaces `DashboardContainer`, which implements legacy Container and Embeddable interfaces, with plain old javascript object implementation returned from `getDashboardApi`. The following are out of scope for this PR and will be accomplished at a later time: 1) re-factoring dashboard folder structure 2) removing all uses of Embeddable and EmbeddableInput types 3) removing legacy types like DashboardContainerInput --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Hannah Mudge <[email protected]> Co-authored-by: Devon Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197281
PR replaces
DashboardContainer, which implements legacy Container and Embeddable interfaces, with plain old javascript object implementation returned fromgetDashboardApi.The following are out of scope for this PR and will be accomplished at a later time: