Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console] Reenable functional tests aside from font size #197362

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 23, 2024

Summary

This is really just a more focused skip application so we can get as many tests running as quickly as possible.

Part of: #193868

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7213

[✅] test/functional/apps/console/config.ts: 25/25 tests passed.

see run history

@mattkime mattkime changed the title reenable some tests [console] Reenable functional tests aside from font size Oct 23, 2024
@mattkime mattkime self-assigned this Oct 23, 2024
@mattkime mattkime added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Oct 23, 2024
@mattkime mattkime marked this pull request as ready for review October 23, 2024 17:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7232

[✅] test/functional/apps/console/config.ts: 200/200 tests passed.

see run history

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime requested a review from ElenaStoeva October 23, 2024 19:26
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with one small suggestion.

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime enabled auto-merge (squash) October 24, 2024 10:04
@mattkime mattkime merged commit f67bc32 into elastic:main Oct 24, 2024
21 of 22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11498506831

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @mattkime

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197362

Questions ?

Please refer to the Backport tool documentation

mattkime added a commit to mattkime/kibana that referenced this pull request Oct 24, 2024
)

## Summary

This is really just a more focused `skip` application so we can get as
many tests running as quickly as possible.

Part of: elastic#193868

(cherry picked from commit f67bc32)

# Conflicts:
#	test/functional/apps/console/_misc_console_behavior.ts
@mattkime
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 25, 2024
mattkime added a commit that referenced this pull request Oct 25, 2024
…) (#197686)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[console] Reenable functional tests aside from font size
(#197362)](#197362)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T11:38:26Z","message":"[console]
Reenable functional tests aside from font size (#197362)\n\n##
Summary\r\n\r\nThis is really just a more focused `skip` application so
we can get as\r\nmany tests running as quickly as possible.\r\n\r\nPart
of:
https://github.com/elastic/kibana/issues/193868","sha":"f67bc3287b7b9a3c4bde49151cc4fec035fb7faf","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"number":197362,"url":"https://github.com/elastic/kibana/pull/197362","mergeCommit":{"message":"[console]
Reenable functional tests aside from font size (#197362)\n\n##
Summary\r\n\r\nThis is really just a more focused `skip` application so
we can get as\r\nmany tests running as quickly as possible.\r\n\r\nPart
of:
https://github.com/elastic/kibana/issues/193868","sha":"f67bc3287b7b9a3c4bde49151cc4fec035fb7faf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197362","number":197362,"mergeCommit":{"message":"[console]
Reenable functional tests aside from font size (#197362)\n\n##
Summary\r\n\r\nThis is really just a more focused `skip` application so
we can get as\r\nmany tests running as quickly as possible.\r\n\r\nPart
of:
https://github.com/elastic/kibana/issues/193868","sha":"f67bc3287b7b9a3c4bde49151cc4fec035fb7faf"}}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants