Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Enable change point detection functional tests #201612

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Nov 25, 2024

Summary

Fixes #200091
Fixes #200836

  • Splits change point detection functional tests into separate groups for dashboard and cases integrations.

Checklist

@darnautov darnautov self-assigned this Nov 25, 2024
@darnautov darnautov changed the title [ML] Enable change point detection function tests [ML] Enable change point detection functional tests Nov 25, 2024
@darnautov
Copy link
Contributor Author

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7472

[✅] x-pack/test/functional/apps/aiops/config.ts: 50/50 tests passed.

see run history

@darnautov darnautov added :ml test_ui_functional release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:ML Team label for ML (also use :ml) Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis backport:version Backport to applied version labels v8.17.0 v8.18.0 labels Nov 25, 2024
@darnautov darnautov marked this pull request as ready for review November 25, 2024 15:53
@darnautov darnautov requested a review from a team as a code owner November 25, 2024 15:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov
Copy link
Contributor Author

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7475

[❌] x-pack/test/functional/apps/aiops/config.ts: 52/80 tests passed.

see run history

@darnautov darnautov added the ci:cloud-deploy Create or update a Cloud deployment label Nov 25, 2024
@darnautov darnautov requested a review from a team as a code owner November 27, 2024 16:09
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov
Copy link
Contributor Author

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7516

[❌] x-pack/test/functional/apps/aiops/config.ts: 0/80 tests passed.

see run history

@darnautov
Copy link
Contributor Author

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 28, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @darnautov

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7531

[✅] x-pack/test/functional/apps/aiops/config.ts: 80/80 tests passed.

see run history

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, great to see the flaky test runner passed!

@darnautov darnautov merged commit 0419606 into elastic:main Nov 28, 2024
8 checks passed
@darnautov darnautov deleted the ml-200091-fix-change-point-tests branch November 28, 2024 14:55
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12071233591

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2024
## Summary

Fixes elastic#200091
Fixes elastic#200836

- Splits change point detection functional tests into separate groups
for dashboard and cases integrations.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 0419606)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2024
## Summary

Fixes elastic#200091
Fixes elastic#200836

- Splits change point detection functional tests into separate groups
for dashboard and cases integrations.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit 0419606)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 28, 2024
…202187)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Enable change point detection functional tests
(#201612)](#201612)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T14:55:40Z","message":"[ML]
Enable change point detection functional tests (#201612)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/200091\r\nFixes
https://github.com/elastic/kibana/issues/200836\r\n\r\n- Splits change
point detection functional tests into separate groups\r\nfor dashboard
and cases integrations.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"04196063288f128d2a1691c85dfbd1b4afe4fd17","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","v9.0.0","Team:ML","ci:cloud-deploy","Feature:ML/AIOps","backport:version","v8.17.0","v8.18.0"],"title":"[ML]
Enable change point detection functional tests
","number":201612,"url":"https://github.com/elastic/kibana/pull/201612","mergeCommit":{"message":"[ML]
Enable change point detection functional tests (#201612)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/200091\r\nFixes
https://github.com/elastic/kibana/issues/200836\r\n\r\n- Splits change
point detection functional tests into separate groups\r\nfor dashboard
and cases integrations.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"04196063288f128d2a1691c85dfbd1b4afe4fd17"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201612","number":201612,"mergeCommit":{"message":"[ML]
Enable change point detection functional tests (#201612)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/200091\r\nFixes
https://github.com/elastic/kibana/issues/200836\r\n\r\n- Splits change
point detection functional tests into separate groups\r\nfor dashboard
and cases integrations.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"04196063288f128d2a1691c85dfbd1b4afe4fd17"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 28, 2024
…202186)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[ML] Enable change point detection functional tests
(#201612)](#201612)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T14:55:40Z","message":"[ML]
Enable change point detection functional tests (#201612)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/200091\r\nFixes
https://github.com/elastic/kibana/issues/200836\r\n\r\n- Splits change
point detection functional tests into separate groups\r\nfor dashboard
and cases integrations.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"04196063288f128d2a1691c85dfbd1b4afe4fd17","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","v9.0.0","Team:ML","ci:cloud-deploy","Feature:ML/AIOps","backport:version","v8.17.0","v8.18.0"],"title":"[ML]
Enable change point detection functional tests
","number":201612,"url":"https://github.com/elastic/kibana/pull/201612","mergeCommit":{"message":"[ML]
Enable change point detection functional tests (#201612)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/200091\r\nFixes
https://github.com/elastic/kibana/issues/200836\r\n\r\n- Splits change
point detection functional tests into separate groups\r\nfor dashboard
and cases integrations.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"04196063288f128d2a1691c85dfbd1b4afe4fd17"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201612","number":201612,"mergeCommit":{"message":"[ML]
Enable change point detection functional tests (#201612)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/200091\r\nFixes
https://github.com/elastic/kibana/issues/200836\r\n\r\n- Splits change
point detection functional tests into separate groups\r\nfor dashboard
and cases integrations.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"04196063288f128d2a1691c85dfbd1b4afe4fd17"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Fixes elastic#200091
Fixes elastic#200836

- Splits change point detection functional tests into separate groups
for dashboard and cases integrations.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_ui_functional v8.17.0 v8.18.0 v9.0.0
Projects
None yet
5 participants