feat(slo): SLO grouping values selector #202364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:feature
kdelemme
commented
Nov 29, 2024
| } | ||
|
|
||
| export function SLOGroupingValueSelector({ slo, groupingKey, value }: Props) { | ||
| const isAvailable = window.location.pathname.includes(SLOS_BASE_PATH); |
There was a problem hiding this comment.
💬 This page can be displayed from the dashboard flyout, it's a little bit tricky to handle correctly so I've decided to disable the selection in this case.
kdelemme
commented
Nov 29, 2024
| sloId: string, | ||
| params: GetSLOInstancesParams | ||
| ): Promise<GetSLOInstancesResponse> { | ||
| const { slo } = await this.definitionClient.execute(sloId, this.spaceId, params?.remoteName); |
There was a problem hiding this comment.
Fetch from the remote cluster if provided, otherwise it uses the repository
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
force-pushed
the
slo/instance-selector
branch
from
e6805a6 to
6d04e55
Compare
kdelemme
commented
Dec 3, 2024
| throw new Error(`Something went wrong. Error: ${error}`); | ||
| } | ||
| }, | ||
| enabled: Boolean(!!sloId && !!groupingKey && instanceId !== ALL_VALUE), |
There was a problem hiding this comment.
💬 Technically the SLOGroupings component should never call this hook without these values, but in order to prevent other misusage, i'm adding this explicitly
kdelemme
commented
Dec 3, 2024
Comment on lines
+110
to
+116
| ...groupingKeyValuePairs | ||
| .filter(([groupingKey]) => groupingKey !== params.groupingKey) | ||
| .map(([groupingKey, groupingValue]) => ({ | ||
| term: { | ||
| [`slo.groupings.${groupingKey}`]: groupingValue, | ||
| }, | ||
| })), |
There was a problem hiding this comment.
💬 We filter the summary documents to match the other grouping key/value pairs. So the values returned for the specified groupingKey form a valid instanceId when set together with the other pairs
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
History
cc @kdelemme |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
(cherry picked from commit 7806861)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [feat(slo): SLO grouping values selector (#202364)](#202364) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T18:51:03Z","message":"feat(slo): SLO grouping values selector (#202364)","sha":"7806861c5fc742cc09156655413d3d5c2ab87fda","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.18.0"],"title":"feat(slo): SLO grouping values selector","number":202364,"url":"https://github.com/elastic/kibana/pull/202364","mergeCommit":{"message":"feat(slo): SLO grouping values selector (#202364)","sha":"7806861c5fc742cc09156655413d3d5c2ab87fda"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202364","number":202364,"mergeCommit":{"message":"feat(slo): SLO grouping values selector (#202364)","sha":"7806861c5fc742cc09156655413d3d5c2ab87fda"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Dec 7, 2024
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198009
🏇🏻 Summary
This PR introduces a way to switch from one instance to another for a given SLO. It replaces the current displaying of the grouping key/value in the SLO details page by a searchable combobox of all possible values for each grouping key.
The list is searchable and excludes the stale SLO instances.
Note
I refactored the existing internal API
GET /slos/{id}/_instanceswhich was not in use from within Kibana. The API is now accessible underGET /slos/{id}/_groupingsThis new API takes two mandatory fields:
groupingKeyandinstanceId. We use the provided instanceId to derive the term filters on the other groupingKeys (if more than one).🧬 Testing
node x-pack/scripts/data_forge.js --events-per-cycle 30 --lookback now-1d --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601/kibanaslo_goruping_value_selection_final.mov