[eem] metadata as keyword #202611
Merged
[eem] metadata as keyword #202611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
release_note:skip
|
Pinging @elastic/obs-entities (Team:obs-entities) |
💚 Build Succeeded
Metrics [docs]
History
cc @klacabane |
tommyers-elastic
approved these changes
Dec 5, 2024
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
klacabane
added a commit
to klacabane/kibana
that referenced
this pull request
Dec 8, 2024
Cast identity fields and metadata fields as keyword to prevent ambiguous
mappings error
### Testing
- setup data
```
PUT service-name-as-keyword
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "keyword"
}
}
}
}
POST service-name-as-keyword/_doc
{
"service.name": "as-keyword"
}
PUT service-name-as-text
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "text"
}
}
}
}
POST service-name-as-text/_doc
{
"service.name": "as-text"
}
```
- data loads successfully in `/app/entity_manager`
_new query_
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
- previous query fails with ambiguous mappings error
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
(cherry picked from commit 58f51fd)
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
Cast identity fields and metadata fields as keyword to prevent ambiguous
mappings error
### Testing
- setup data
```
PUT service-name-as-keyword
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "keyword"
}
}
}
}
POST service-name-as-keyword/_doc
{
"service.name": "as-keyword"
}
PUT service-name-as-text
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "text"
}
}
}
}
POST service-name-as-text/_doc
{
"service.name": "as-text"
}
```
- data loads successfully in `/app/entity_manager`
_new query_
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
- previous query fails with ambiguous mappings error
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
Cast identity fields and metadata fields as keyword to prevent ambiguous
mappings error
### Testing
- setup data
```
PUT service-name-as-keyword
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "keyword"
}
}
}
}
POST service-name-as-keyword/_doc
{
"service.name": "as-keyword"
}
PUT service-name-as-text
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "text"
}
}
}
}
POST service-name-as-text/_doc
{
"service.name": "as-text"
}
```
- data loads successfully in `/app/entity_manager`
_new query_
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
- previous query fails with ambiguous mappings error
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
klacabane
added a commit
that referenced
this pull request
Dec 9, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[eem] metadata as keyword (#202611)](#202611) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Lacabane","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T11:57:12Z","message":"[eem] metadata as keyword (#202611)\n\nCast identity fields and metadata fields as keyword to prevent ambiguous\r\nmappings error\r\n\r\n### Testing\r\n\r\n- setup data\r\n```\r\nPUT service-name-as-keyword\r\n{\r\n \"mappings\": {\r\n \"dynamic\": false,\r\n \"properties\": {\r\n \"service.name\": {\r\n \"type\": \"keyword\"\r\n }\r\n }\r\n }\r\n}\r\n\r\nPOST service-name-as-keyword/_doc\r\n{\r\n \"service.name\": \"as-keyword\"\r\n}\r\n\r\nPUT service-name-as-text\r\n{\r\n \"mappings\": {\r\n \"dynamic\": false,\r\n \"properties\": {\r\n \"service.name\": {\r\n \"type\": \"text\"\r\n }\r\n }\r\n }\r\n}\r\n\r\n\r\nPOST service-name-as-text/_doc\r\n{\r\n \"service.name\": \"as-text\"\r\n}\r\n```\r\n\r\n- data loads successfully in `/app/entity_manager`\r\n\r\n\r\n_new query_\r\n```\r\nPOST _query\r\n{\r\n \"query\": \"\"\"FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = \"service\", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10\"\"\"\r\n}\r\n```\r\n\r\n- previous query fails with ambiguous mappings error\r\n```\r\nPOST _query\r\n{\r\n \"query\": \"\"\"FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = \"service\", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10\"\"\"\r\n}\r\n```","sha":"58f51fdac79937cd3706c9f202e460b7a568fc12","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","backport:prev-minor","Team:obs-entities"],"number":202611,"url":"https://github.com/elastic/kibana/pull/202611","mergeCommit":{"message":"[eem] metadata as keyword (#202611)\n\nCast identity fields and metadata fields as keyword to prevent ambiguous\r\nmappings error\r\n\r\n### Testing\r\n\r\n- setup data\r\n```\r\nPUT service-name-as-keyword\r\n{\r\n \"mappings\": {\r\n \"dynamic\": false,\r\n \"properties\": {\r\n \"service.name\": {\r\n \"type\": \"keyword\"\r\n }\r\n }\r\n }\r\n}\r\n\r\nPOST service-name-as-keyword/_doc\r\n{\r\n \"service.name\": \"as-keyword\"\r\n}\r\n\r\nPUT service-name-as-text\r\n{\r\n \"mappings\": {\r\n \"dynamic\": false,\r\n \"properties\": {\r\n \"service.name\": {\r\n \"type\": \"text\"\r\n }\r\n }\r\n }\r\n}\r\n\r\n\r\nPOST service-name-as-text/_doc\r\n{\r\n \"service.name\": \"as-text\"\r\n}\r\n```\r\n\r\n- data loads successfully in `/app/entity_manager`\r\n\r\n\r\n_new query_\r\n```\r\nPOST _query\r\n{\r\n \"query\": \"\"\"FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = \"service\", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10\"\"\"\r\n}\r\n```\r\n\r\n- previous query fails with ambiguous mappings error\r\n```\r\nPOST _query\r\n{\r\n \"query\": \"\"\"FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = \"service\", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10\"\"\"\r\n}\r\n```","sha":"58f51fdac79937cd3706c9f202e460b7a568fc12"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202611","number":202611,"mergeCommit":{"message":"[eem] metadata as keyword (#202611)\n\nCast identity fields and metadata fields as keyword to prevent ambiguous\r\nmappings error\r\n\r\n### Testing\r\n\r\n- setup data\r\n```\r\nPUT service-name-as-keyword\r\n{\r\n \"mappings\": {\r\n \"dynamic\": false,\r\n \"properties\": {\r\n \"service.name\": {\r\n \"type\": \"keyword\"\r\n }\r\n }\r\n }\r\n}\r\n\r\nPOST service-name-as-keyword/_doc\r\n{\r\n \"service.name\": \"as-keyword\"\r\n}\r\n\r\nPUT service-name-as-text\r\n{\r\n \"mappings\": {\r\n \"dynamic\": false,\r\n \"properties\": {\r\n \"service.name\": {\r\n \"type\": \"text\"\r\n }\r\n }\r\n }\r\n}\r\n\r\n\r\nPOST service-name-as-text/_doc\r\n{\r\n \"service.name\": \"as-text\"\r\n}\r\n```\r\n\r\n- data loads successfully in `/app/entity_manager`\r\n\r\n\r\n_new query_\r\n```\r\nPOST _query\r\n{\r\n \"query\": \"\"\"FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = \"service\", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10\"\"\"\r\n}\r\n```\r\n\r\n- previous query fails with ambiguous mappings error\r\n```\r\nPOST _query\r\n{\r\n \"query\": \"\"\"FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = \"service\", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10\"\"\"\r\n}\r\n```","sha":"58f51fdac79937cd3706c9f202e460b7a568fc12"}}]}] BACKPORT-->
kibanamachine
added
v8.18.0
and removed
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
Cast identity fields and metadata fields as keyword to prevent ambiguous
mappings error
### Testing
- setup data
```
PUT service-name-as-keyword
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "keyword"
}
}
}
}
POST service-name-as-keyword/_doc
{
"service.name": "as-keyword"
}
PUT service-name-as-text
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "text"
}
}
}
}
POST service-name-as-text/_doc
{
"service.name": "as-text"
}
```
- data loads successfully in `/app/entity_manager`
_new query_
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
- previous query fails with ambiguous mappings error
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
Cast identity fields and metadata fields as keyword to prevent ambiguous
mappings error
### Testing
- setup data
```
PUT service-name-as-keyword
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "keyword"
}
}
}
}
POST service-name-as-keyword/_doc
{
"service.name": "as-keyword"
}
PUT service-name-as-text
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "text"
}
}
}
}
POST service-name-as-text/_doc
{
"service.name": "as-text"
}
```
- data loads successfully in `/app/entity_manager`
_new query_
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
- previous query fails with ambiguous mappings error
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
Cast identity fields and metadata fields as keyword to prevent ambiguous
mappings error
### Testing
- setup data
```
PUT service-name-as-keyword
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "keyword"
}
}
}
}
POST service-name-as-keyword/_doc
{
"service.name": "as-keyword"
}
PUT service-name-as-text
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "text"
}
}
}
}
POST service-name-as-text/_doc
{
"service.name": "as-text"
}
```
- data loads successfully in `/app/entity_manager`
_new query_
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
- previous query fails with ambiguous mappings error
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Cast identity fields and metadata fields as keyword to prevent ambiguous
mappings error
### Testing
- setup data
```
PUT service-name-as-keyword
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "keyword"
}
}
}
}
POST service-name-as-keyword/_doc
{
"service.name": "as-keyword"
}
PUT service-name-as-text
{
"mappings": {
"dynamic": false,
"properties": {
"service.name": {
"type": "text"
}
}
}
}
POST service-name-as-text/_doc
{
"service.name": "as-text"
}
```
- data loads successfully in `/app/entity_manager`
_new query_
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name::keyword IS NOT NULL | STATS BY service.name::keyword | RENAME `service.name::keyword` AS service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
- previous query fails with ambiguous mappings error
```
POST _query
{
"query": """FROM service-name-as* | WHERE service.name IS NOT NULL | STATS BY service.name | EVAL entity.type = "service", entity.id = service.name, entity.display_name = entity.id | SORT entity.id ASC | LIMIT 10"""
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast identity fields and metadata fields as keyword to prevent ambiguous mappings error
Testing
/app/entity_managernew query