[Ownership] Add code owner to ftr failure report #203076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
wayneseymour
force-pushed
the
add-owner-to-ftr-failure-report
branch
from
e685aaf to
8c7567f
Compare
|
@elasticmachine merge upstream |
…mour/kibana into add-owner-to-ftr-failure-report
dmlemeshko
reviewed
Dec 10, 2024
packages/kbn-failed-test-reporter-cli/failed_tests_reporter/get_failures.ts
Outdated
Show resolved
Hide resolved
…mour/kibana into add-owner-to-ftr-failure-report
Ikuni17
approved these changes
Dec 12, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
delanni
approved these changes
Dec 16, 2024
💚 Build Succeeded
Metrics [docs]
History
|
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Resolves: elastic#202687 ### For Reviewers #### To test locally, make a test fail, something like ``` diff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts index 0e29b29e96e..78976e6d54b 100644 --- a/test/functional/apps/console/_autocomplete.ts +++ b/test/functional/apps/console/_autocomplete.ts @@ -50,14 +50,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.console.setAutocompleteTrace(false); }); - it('should provide basic auto-complete functionality', async () => { + it.only('should provide basic auto-complete functionality', async () => { await PageObjects.console.enterText(`GET _search\n`); await PageObjects.console.pressEnter(); await PageObjects.console.enterText(`{\n\t"query": {`); await PageObjects.console.pressEnter(); await PageObjects.console.sleepForDebouncePeriod(); await PageObjects.console.promptAutocomplete(); - expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true); + expect(false).to.be.eql(true); }); it('should not show duplicate suggestions', async () => { ``` #### Then run the tests: `TEST_BROWSER_HEADLESS=1 CI=1 node scripts/functional_tests --config=test/functional/apps/console/config.ts --bail` #### Then run the reporter to see the html file `JOB_NAME=elastic+kibana+7.x node scripts/report_failed_tests --build-url="${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}" 'target/junit/**/*.xml' --no-github-update --no-index-errors` #### Lastly, inspect the HTML File `grep elastic target/test_failures/*.html -B 2` ``` <div> <strong>Owners</strong>: <pre>elastic/kibana-management</pre> -- </div> <div> <a href="https://github.com/elastic/kibana/issues/156926">https://github.com/elastic/kibana/issues/156926</a> -- <h5>Stdout</h5> <pre>Failed Tests Reporter: - Test has failed 1 times on tracked branches: elastic#156926 Failed Tests Reporter: - Test has failed 1 times on tracked branches: elastic#156926 Failed Tests Reporter: - Test has failed 1 times on tracked branches: elastic#156926 ``` Notice the `<pre>elastic/kibana-management</pre>` in the output of grep Also, you can continue verification of the ownership value, via: `node scripts/get_owners_for_file.js --file test/functional/apps/console/_autocomplete.ts` ``` succ Found matching entry in .github/CODEOWNERS: test/functional/apps/console/*.ts elastic/kibana-management ``` --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Resolves: elastic#202687 ### For Reviewers #### To test locally, make a test fail, something like ``` diff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts index 0e29b29e96e..78976e6d54b 100644 --- a/test/functional/apps/console/_autocomplete.ts +++ b/test/functional/apps/console/_autocomplete.ts @@ -50,14 +50,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.console.setAutocompleteTrace(false); }); - it('should provide basic auto-complete functionality', async () => { + it.only('should provide basic auto-complete functionality', async () => { await PageObjects.console.enterText(`GET _search\n`); await PageObjects.console.pressEnter(); await PageObjects.console.enterText(`{\n\t"query": {`); await PageObjects.console.pressEnter(); await PageObjects.console.sleepForDebouncePeriod(); await PageObjects.console.promptAutocomplete(); - expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true); + expect(false).to.be.eql(true); }); it('should not show duplicate suggestions', async () => { ``` #### Then run the tests: `TEST_BROWSER_HEADLESS=1 CI=1 node scripts/functional_tests --config=test/functional/apps/console/config.ts --bail` #### Then run the reporter to see the html file `JOB_NAME=elastic+kibana+7.x node scripts/report_failed_tests --build-url="${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}" 'target/junit/**/*.xml' --no-github-update --no-index-errors` #### Lastly, inspect the HTML File `grep elastic target/test_failures/*.html -B 2` ``` <div> <strong>Owners</strong>: <pre>elastic/kibana-management</pre> -- </div> <div> <a href="https://github.com/elastic/kibana/issues/156926">https://github.com/elastic/kibana/issues/156926</a> -- <h5>Stdout</h5> <pre>Failed Tests Reporter: - Test has failed 1 times on tracked branches: elastic#156926 Failed Tests Reporter: - Test has failed 1 times on tracked branches: elastic#156926 Failed Tests Reporter: - Test has failed 1 times on tracked branches: elastic#156926 ``` Notice the `<pre>elastic/kibana-management</pre>` in the output of grep Also, you can continue verification of the ownership value, via: `node scripts/get_owners_for_file.js --file test/functional/apps/console/_autocomplete.ts` ``` succ Found matching entry in .github/CODEOWNERS: test/functional/apps/console/*.ts elastic/kibana-management ``` --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 82f0e2c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
wayneseymour
added a commit
that referenced
this pull request
Dec 20, 2024
…4995) # Backport This will backport the following commits from `main` to `8.x`: - [[Ownership] Add code owner to ftr failure report (#203076)](#203076) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tre","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T17:05:20Z","message":"[Ownership] Add code owner to ftr failure report (#203076)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/202687\r\n\r\n### For Reviewers \r\n#### To test locally, make a test fail, something like \r\n```\r\ndiff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts\r\nindex 0e29b29e96e..78976e6d54b 100644\r\n--- a/test/functional/apps/console/_autocomplete.ts\r\n+++ b/test/functional/apps/console/_autocomplete.ts\r\n@@ -50,14 +50,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {\r\n await PageObjects.console.setAutocompleteTrace(false);\r\n });\r\n \r\n- it('should provide basic auto-complete functionality', async () => {\r\n+ it.only('should provide basic auto-complete functionality', async () => {\r\n await PageObjects.console.enterText(`GET _search\\n`);\r\n await PageObjects.console.pressEnter();\r\n await PageObjects.console.enterText(`{\\n\\t\"query\": {`);\r\n await PageObjects.console.pressEnter();\r\n await PageObjects.console.sleepForDebouncePeriod();\r\n await PageObjects.console.promptAutocomplete();\r\n- expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);\r\n+ expect(false).to.be.eql(true);\r\n });\r\n \r\n it('should not show duplicate suggestions', async () => {\r\n```\r\n\r\n#### Then run the tests:\r\n`TEST_BROWSER_HEADLESS=1 CI=1 node scripts/functional_tests\r\n--config=test/functional/apps/console/config.ts --bail`\r\n\r\n#### Then run the reporter to see the html file\r\n`JOB_NAME=elastic+kibana+7.x node scripts/report_failed_tests\r\n--build-url=\"${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}\"\r\n'target/junit/**/*.xml' --no-github-update --no-index-errors`\r\n\r\n#### Lastly, inspect the HTML File\r\n`grep elastic target/test_failures/*.html -B 2`\r\n```\r\n <div>\r\n <strong>Owners</strong>:\r\n <pre>elastic/kibana-management</pre>\r\n--\r\n </div>\r\n <div>\r\n <a href=\"https://github.com/elastic/kibana/issues/156926\">https://github.com/elastic/kibana/issues/156926</a>\r\n--\r\n <h5>Stdout</h5>\r\n <pre>Failed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n\r\nFailed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n\r\nFailed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n```\r\n\r\nNotice the `<pre>elastic/kibana-management</pre>` in the output of grep\r\n\r\nAlso, you can continue verification of the ownership value, via: `node\r\nscripts/get_owners_for_file.js --file\r\ntest/functional/apps/console/_autocomplete.ts`\r\n```\r\n succ Found matching entry in .github/CODEOWNERS:\r\n test/functional/apps/console/*.ts elastic/kibana-management\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"82f0e2cd54f8fd84c75beebe2853fbf63ff1dab9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","FTR"],"number":203076,"url":"https://github.com/elastic/kibana/pull/203076","mergeCommit":{"message":"[Ownership] Add code owner to ftr failure report (#203076)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/202687\r\n\r\n### For Reviewers \r\n#### To test locally, make a test fail, something like \r\n```\r\ndiff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts\r\nindex 0e29b29e96e..78976e6d54b 100644\r\n--- a/test/functional/apps/console/_autocomplete.ts\r\n+++ b/test/functional/apps/console/_autocomplete.ts\r\n@@ -50,14 +50,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {\r\n await PageObjects.console.setAutocompleteTrace(false);\r\n });\r\n \r\n- it('should provide basic auto-complete functionality', async () => {\r\n+ it.only('should provide basic auto-complete functionality', async () => {\r\n await PageObjects.console.enterText(`GET _search\\n`);\r\n await PageObjects.console.pressEnter();\r\n await PageObjects.console.enterText(`{\\n\\t\"query\": {`);\r\n await PageObjects.console.pressEnter();\r\n await PageObjects.console.sleepForDebouncePeriod();\r\n await PageObjects.console.promptAutocomplete();\r\n- expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);\r\n+ expect(false).to.be.eql(true);\r\n });\r\n \r\n it('should not show duplicate suggestions', async () => {\r\n```\r\n\r\n#### Then run the tests:\r\n`TEST_BROWSER_HEADLESS=1 CI=1 node scripts/functional_tests\r\n--config=test/functional/apps/console/config.ts --bail`\r\n\r\n#### Then run the reporter to see the html file\r\n`JOB_NAME=elastic+kibana+7.x node scripts/report_failed_tests\r\n--build-url=\"${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}\"\r\n'target/junit/**/*.xml' --no-github-update --no-index-errors`\r\n\r\n#### Lastly, inspect the HTML File\r\n`grep elastic target/test_failures/*.html -B 2`\r\n```\r\n <div>\r\n <strong>Owners</strong>:\r\n <pre>elastic/kibana-management</pre>\r\n--\r\n </div>\r\n <div>\r\n <a href=\"https://github.com/elastic/kibana/issues/156926\">https://github.com/elastic/kibana/issues/156926</a>\r\n--\r\n <h5>Stdout</h5>\r\n <pre>Failed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n\r\nFailed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n\r\nFailed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n```\r\n\r\nNotice the `<pre>elastic/kibana-management</pre>` in the output of grep\r\n\r\nAlso, you can continue verification of the ownership value, via: `node\r\nscripts/get_owners_for_file.js --file\r\ntest/functional/apps/console/_autocomplete.ts`\r\n```\r\n succ Found matching entry in .github/CODEOWNERS:\r\n test/functional/apps/console/*.ts elastic/kibana-management\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"82f0e2cd54f8fd84c75beebe2853fbf63ff1dab9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203076","number":203076,"mergeCommit":{"message":"[Ownership] Add code owner to ftr failure report (#203076)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/202687\r\n\r\n### For Reviewers \r\n#### To test locally, make a test fail, something like \r\n```\r\ndiff --git a/test/functional/apps/console/_autocomplete.ts b/test/functional/apps/console/_autocomplete.ts\r\nindex 0e29b29e96e..78976e6d54b 100644\r\n--- a/test/functional/apps/console/_autocomplete.ts\r\n+++ b/test/functional/apps/console/_autocomplete.ts\r\n@@ -50,14 +50,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {\r\n await PageObjects.console.setAutocompleteTrace(false);\r\n });\r\n \r\n- it('should provide basic auto-complete functionality', async () => {\r\n+ it.only('should provide basic auto-complete functionality', async () => {\r\n await PageObjects.console.enterText(`GET _search\\n`);\r\n await PageObjects.console.pressEnter();\r\n await PageObjects.console.enterText(`{\\n\\t\"query\": {`);\r\n await PageObjects.console.pressEnter();\r\n await PageObjects.console.sleepForDebouncePeriod();\r\n await PageObjects.console.promptAutocomplete();\r\n- expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);\r\n+ expect(false).to.be.eql(true);\r\n });\r\n \r\n it('should not show duplicate suggestions', async () => {\r\n```\r\n\r\n#### Then run the tests:\r\n`TEST_BROWSER_HEADLESS=1 CI=1 node scripts/functional_tests\r\n--config=test/functional/apps/console/config.ts --bail`\r\n\r\n#### Then run the reporter to see the html file\r\n`JOB_NAME=elastic+kibana+7.x node scripts/report_failed_tests\r\n--build-url=\"${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}\"\r\n'target/junit/**/*.xml' --no-github-update --no-index-errors`\r\n\r\n#### Lastly, inspect the HTML File\r\n`grep elastic target/test_failures/*.html -B 2`\r\n```\r\n <div>\r\n <strong>Owners</strong>:\r\n <pre>elastic/kibana-management</pre>\r\n--\r\n </div>\r\n <div>\r\n <a href=\"https://github.com/elastic/kibana/issues/156926\">https://github.com/elastic/kibana/issues/156926</a>\r\n--\r\n <h5>Stdout</h5>\r\n <pre>Failed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n\r\nFailed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n\r\nFailed Tests Reporter:\r\n - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/156926\r\n```\r\n\r\nNotice the `<pre>elastic/kibana-management</pre>` in the output of grep\r\n\r\nAlso, you can continue verification of the ownership value, via: `node\r\nscripts/get_owners_for_file.js --file\r\ntest/functional/apps/console/_autocomplete.ts`\r\n```\r\n succ Found matching entry in .github/CODEOWNERS:\r\n test/functional/apps/console/*.ts elastic/kibana-management\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"82f0e2cd54f8fd84c75beebe2853fbf63ff1dab9"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #202687
For Reviewers
To test locally, make a test fail, something like
Then run the tests:
TEST_BROWSER_HEADLESS=1 CI=1 node scripts/functional_tests --config=test/functional/apps/console/config.ts --bailThen run the reporter to see the html file
JOB_NAME=elastic+kibana+7.x node scripts/report_failed_tests --build-url="${BUILDKITE_BUILD_URL}#${BUILDKITE_JOB_ID}" 'target/junit/**/*.xml' --no-github-update --no-index-errorsLastly, inspect the HTML File
grep elastic target/test_failures/*.html -B 2Notice the
<pre>elastic/kibana-management</pre>in the output of grepAlso, you can continue verification of the ownership value, via:
node scripts/get_owners_for_file.js --file test/functional/apps/console/_autocomplete.ts