Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] [Dataset Quality] Stringify ignored values before rendering #203312

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Dec 6, 2024

📝 Summary

This json-stringifies the values of the _ignored fields in the "quality issues" section of the "logs overview" tab. The tab is shown in Discover when the space is an "Observability" space or the serverless project is an "Observability" project and the document is a log entry document.

🎨 Previews

image

🕵️ Testing

  • Create a Kibana deployment with an "Observability" context (by creating a space of that type or by creating an "Observability" serverless project.
  • Ingest a document with a malformed value in a mapped field, that is an object (such as an empty object in a flattened field).
  • Open the fly-out for that document and expand the "Quality Issues" section.

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience release_note:fix backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-logs Observability Logs User Experience Team labels Dec 6, 2024
@weltenwort weltenwort self-assigned this Dec 6, 2024
@weltenwort weltenwort force-pushed the discover-dataset-quality-stringify-ignored-values branch from 23eb005 to 6358f6f Compare December 6, 2024 18:05
@weltenwort weltenwort marked this pull request as ready for review December 6, 2024 18:06
@weltenwort weltenwort requested a review from a team as a code owner December 6, 2024 18:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedDocViewer 115.8KB 115.8KB +16.0B

History

cc @weltenwort

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weltenwort weltenwort merged commit 38f30a9 into elastic:main Dec 11, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12274481796

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2024
elastic#203312)

This json-stringifies the values of the `_ignored` fields in the
"quality issues" section of the "logs overview" tab. The tab is shown in
Discover when the space is an "Observability" space or the serverless
project is an "Observability" project and the document is a log entry
document.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 38f30a9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 11, 2024
…ndering (#203312) (#203747)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] [Dataset Quality] Stringify ignored values before
rendering (#203312)](#203312)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Felix
Stürmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T10:30:26Z","message":"[Discover]
[Dataset Quality] Stringify ignored values before rendering
(#203312)\n\nThis json-stringifies the values of the `_ignored` fields
in the\r\n\"quality issues\" section of the \"logs overview\" tab. The
tab is shown in\r\nDiscover when the space is an \"Observability\" space
or the serverless\r\nproject is an \"Observability\" project and the
document is a log entry\r\ndocument.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"38f30a9fe002c65e1b483e2de339f3c9704799d5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[Discover]
[Dataset Quality] Stringify ignored values before
rendering","number":203312,"url":"https://github.com/elastic/kibana/pull/203312","mergeCommit":{"message":"[Discover]
[Dataset Quality] Stringify ignored values before rendering
(#203312)\n\nThis json-stringifies the values of the `_ignored` fields
in the\r\n\"quality issues\" section of the \"logs overview\" tab. The
tab is shown in\r\nDiscover when the space is an \"Observability\" space
or the serverless\r\nproject is an \"Observability\" project and the
document is a log entry\r\ndocument.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"38f30a9fe002c65e1b483e2de339f3c9704799d5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203312","number":203312,"mergeCommit":{"message":"[Discover]
[Dataset Quality] Stringify ignored values before rendering
(#203312)\n\nThis json-stringifies the values of the `_ignored` fields
in the\r\n\"quality issues\" section of the \"logs overview\" tab. The
tab is shown in\r\nDiscover when the space is an \"Observability\" space
or the serverless\r\nproject is an \"Observability\" project and the
document is a log entry\r\ndocument.\r\n\r\nCo-authored-by: Elastic
Machine
<[email protected]>","sha":"38f30a9fe002c65e1b483e2de339f3c9704799d5"}}]}]
BACKPORT-->

Co-authored-by: Felix Stürmer <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
elastic#203312)

This json-stringifies the values of the `_ignored` fields in the
"quality issues" section of the "logs overview" tab. The tab is shown in
Discover when the space is an "Observability" space or the serverless
project is an "Observability" project and the document is a log entry
document.

Co-authored-by: Elastic Machine <[email protected]>
@weltenwort
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

weltenwort added a commit to weltenwort/kibana that referenced this pull request Dec 16, 2024
elastic#203312)

This json-stringifies the values of the `_ignored` fields in the
"quality issues" section of the "logs overview" tab. The tab is shown in
Discover when the space is an "Observability" space or the serverless
project is an "Observability" project and the document is a log entry
document.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 38f30a9)
weltenwort added a commit that referenced this pull request Dec 16, 2024
…endering (#203312) (#204362)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Discover] [Dataset Quality] Stringify ignored values before
rendering (#203312)](#203312)

<!--- Backport version: 8.9.8 -->

### Questions?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:fix Team:obs-ux-logs Observability Logs User Experience Team v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] [Dataset Quality] Quality issue section can't handle object values
4 participants