-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Enable actions in document details preview footer #203691
[Security Solution] Enable actions in document details preview footer #203691
Conversation
f22ab8f
to
d51af8d
Compare
d51af8d
to
f88716e
Compare
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of comments we can discuss on Monday:
- do we want to have the action left aligned? Have you tried centered or right aligned (next to the
Take action
button)
-
I'm not a fan of using the
footer.tsx
file from theright
folder inside thepreview
folder. What I had in mind for this feature was to duplicate some code and have the preview footer do everything itself, or move some of the logic to theshared
folder (either the entire footer code or some of its content -
while I understand why you named the property
additionalActions
(I'm guessing to be more flexible in the future?) I feel like it's also a bit vague and we could name it a bit more specifically (related to navigating to the full flyout). Granted that we want to keep this strucutre (see my second point above).
@PhilippeOberti thanks for the review!
Frankly I can do any design, but I didn't get specific directions from UIUX. I can try a couple alignments
Me neither, I think the biggest thing is the right footer has all the take actions hooks, so direct copy and paste feels redundant to me. Ideally we should extract all the hooks into a separate component and call it Another consideration is how there is stuff outside of the
|
Briefly summarizing a Zoom meeting discussion:
let's see how having the action right aligned looks!
Let's see if extracting all the Take Action logic in its own component would work. This way we would have the Take Action logic self contained and we would use that component in both footers (the one in If this does not work, happens to be too complex or too much code change, what you have no works @christineweng. We can just move the |
7baacc2
to
176e4c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for implementing the suggested change related to the Take Action button, I really like this implementation.
Code LGTM and I desk tested everything looks good!
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Async chunks
History
|
Starting backport for target branches: 8.x |
…elastic#203691) ## Summary Updated document details preview footer to also show actions ### Before <img width="1481" alt="image" src="https://github.com/user-attachments/assets/aace12aa-f3d1-4fe2-a3b7-392878207f39" /> ### After - Users can perform alert/event actions in a preview ![image](https://github.com/user-attachments/assets/d42be26d-9d4a-4701-bc88-92549ebfb65c) - In analyzer, when examining an event, event actions are also available ![image](https://github.com/user-attachments/assets/d30515d9-b428-4112-86f8-9bb872eaf921) - No change to flyout in rule creation workflow, action is not available in preview nor non-preview ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 7aac71c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…footer (#203691) (#204504) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Enable actions in document details preview footer (#203691)](#203691) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T23:27:47Z","message":"[Security Solution] Enable actions in document details preview footer (#203691)\n\n## Summary\r\n\r\nUpdated document details preview footer to also show actions\r\n### Before\r\n<img width=\"1481\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/aace12aa-f3d1-4fe2-a3b7-392878207f39\"\r\n/>\r\n\r\n\r\n### After \r\n- Users can perform alert/event actions in a preview\r\n\r\n![image](https://github.com/user-attachments/assets/d42be26d-9d4a-4701-bc88-92549ebfb65c)\r\n\r\n- In analyzer, when examining an event, event actions are also available\r\n\r\n![image](https://github.com/user-attachments/assets/d30515d9-b428-4112-86f8-9bb872eaf921)\r\n\r\n- No change to flyout in rule creation workflow, action is not available\r\nin preview nor non-preview\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7aac71c2aa5eb78f57bfe7bbb047104766b55a30","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.18.0"],"title":"[Security Solution] Enable actions in document details preview footer","number":203691,"url":"https://github.com/elastic/kibana/pull/203691","mergeCommit":{"message":"[Security Solution] Enable actions in document details preview footer (#203691)\n\n## Summary\r\n\r\nUpdated document details preview footer to also show actions\r\n### Before\r\n<img width=\"1481\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/aace12aa-f3d1-4fe2-a3b7-392878207f39\"\r\n/>\r\n\r\n\r\n### After \r\n- Users can perform alert/event actions in a preview\r\n\r\n![image](https://github.com/user-attachments/assets/d42be26d-9d4a-4701-bc88-92549ebfb65c)\r\n\r\n- In analyzer, when examining an event, event actions are also available\r\n\r\n![image](https://github.com/user-attachments/assets/d30515d9-b428-4112-86f8-9bb872eaf921)\r\n\r\n- No change to flyout in rule creation workflow, action is not available\r\nin preview nor non-preview\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7aac71c2aa5eb78f57bfe7bbb047104766b55a30"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203691","number":203691,"mergeCommit":{"message":"[Security Solution] Enable actions in document details preview footer (#203691)\n\n## Summary\r\n\r\nUpdated document details preview footer to also show actions\r\n### Before\r\n<img width=\"1481\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/aace12aa-f3d1-4fe2-a3b7-392878207f39\"\r\n/>\r\n\r\n\r\n### After \r\n- Users can perform alert/event actions in a preview\r\n\r\n![image](https://github.com/user-attachments/assets/d42be26d-9d4a-4701-bc88-92549ebfb65c)\r\n\r\n- In analyzer, when examining an event, event actions are also available\r\n\r\n![image](https://github.com/user-attachments/assets/d30515d9-b428-4112-86f8-9bb872eaf921)\r\n\r\n- No change to flyout in rule creation workflow, action is not available\r\nin preview nor non-preview\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7aac71c2aa5eb78f57bfe7bbb047104766b55a30"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
…elastic#203691) ## Summary Updated document details preview footer to also show actions ### Before <img width="1481" alt="image" src="https://github.com/user-attachments/assets/aace12aa-f3d1-4fe2-a3b7-392878207f39" /> ### After - Users can perform alert/event actions in a preview ![image](https://github.com/user-attachments/assets/d42be26d-9d4a-4701-bc88-92549ebfb65c) - In analyzer, when examining an event, event actions are also available ![image](https://github.com/user-attachments/assets/d30515d9-b428-4112-86f8-9bb872eaf921) - No change to flyout in rule creation workflow, action is not available in preview nor non-preview ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
Updated document details preview footer to also show actions
Before
After
Users can perform alert/event actions in a preview
In analyzer, when examining an event, event actions are also available
No change to flyout in rule creation workflow, action is not available in preview nor non-preview
Checklist