🌊 Streams: Show data retention on stream #204125

flash1293 · 2024-12-12T20:00:14Z

Show data retention on streams

In case of a policy, the name of the policy is shown (badge is clickable and leads to the edit page of the policy):

In case of DLM, the effect retention is shown:

This is just the display piece, editing retention will be added later on.

This PR adjusts the base streams data stream settings to use a localized data stream retention configuration to make it compatible with serverless.

…fix'

…ata-retention

…-fix'

patpscal · 2024-12-19T14:09:40Z

Wonderful @flash1293 - just one detail now that we are with this piece, can we make it so we use the <EuiBadge color="hollow" ? thanks a lot!

…93/kibana into flash1293/streams-data-retention

flash1293 · 2024-12-19T15:33:08Z

Thanks @patpscal , fixed that

tonyghiani · 2024-12-19T15:42:30Z

...es/shared/index-lifecycle-management/index_lifecycle_management_common_shared/src/locator.ts

+export interface IlmLocatorParams extends SerializableRecord {
+  page: 'policies_list' | 'policy_edit' | 'policy_create';
+  policyName?: string;
+}


suggestion: should this go into src/platform/packages/shared/deeplinks/management as other many other apps hold there the locator params? That would let you revert the visibility change for index-lifecycle-management plugin.

I'm not sure that's the right place - it looks like this is just for the top level app routing, not for specific locators within these apps.

As not all management apps are owned by the same team, I would like to keep this in a place owned by stack management as they will probably change the locator and the app itself at the same time.

But happy to go with what @elastic/kibana-management prefers here. If you want to go with a more elaborate solution I can also duplicate and inline the type for now and leave a todo, as it's more of a side quest of this PR

Agree, the comment was not meant to be a blocker but to avoid switching visibility on a plugin that would then be mistakenly located in the new dir structure. I'll defer to what the Kibana team feels is best for this case, not a blocker on my end.

I'd like to avoid changing the visibility of this plugin although at the moment I'm not sure of the best way to do that. Is the locator API a good option?

After a bit more research, I think moving the plugin is the right call. Its probably best to use the locator API but I haven't fully wrapped my head around it.

If the plugin needs to be moved, that could happen in its own PR.

Actually, I think there is an easier way - check the latest version of this. There is a shared package under x-pack/platform/packages/shared/index-lifecycle-management already, I moved the type over there.

tonyghiani

Codewise LGTM, there is a minor comment already discussed.

…ata-retention

…93/kibana into flash1293/streams-data-retention

mattkime

codeowner changes lgtm

dgieselaar · 2024-12-30T08:25:09Z

@elasticmachine merge upstream

tonyghiani · 2024-12-30T08:49:40Z

@flash1293 the change to move the type under x-pack/platform/packages/shared/index-lifecycle-management LGTM, seems the tests are failing cause the lifecycle property is required in the response, but the fixtures used in those tests don't include it, updating those fixtures should fix them

…ata-retention

elasticmachine · 2025-01-08T17:37:25Z

💚 Build Succeeded

Buildkite Build
Commit: 5bb5bf8

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`indexLifecycleManagement`	241	242	+1
`streamsApp`	200	203	+3
`synthetics`	976	977	+1
total			+5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/index-lifecycle-management-common-shared`	73	76	+3
`@kbn/streams-schema`	86	88	+2
`indexLifecycleManagement`	4	0	-4
total			+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`streamsApp`	190.6KB	191.5KB	+922.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`indexLifecycleManagement`	27.5KB	27.5KB	-51.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/index-lifecycle-management-common-shared`	75	78	+3
`@kbn/streams-schema`	86	88	+2
`indexLifecycleManagement`	4	0	-4
total			+1

History

kibanamachine · 2025-01-09T08:25:36Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12686159610

kibanamachine · 2025-01-09T08:30:40Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - 🌊 Stream overview page (#204079) - [Streams] Make root stream selectively immutable (#205609) - [Streams] Dashboard linking (#204309)

Manual backport

To create the backport manually run:

node scripts/backport --pr 204125

Questions ?

Please refer to the Backport tool documentation

Show data retention on streams In case of a policy, the name of the policy is shown (badge is clickable and leads to the edit page of the policy): <img width="524" alt="Screenshot 2024-12-12 at 20 57 36" src="https://github.com/user-attachments/assets/2664b45b-2473-49c4-b1d6-dccb8fe48d43" /> In case of DLM, the effect retention is shown: <img width="532" alt="Screenshot 2024-12-12 at 20 58 42" src="https://github.com/user-attachments/assets/07ca8086-75e2-45f8-9d71-17bd0a76ebe5" /> This is just the display piece, editing retention will be added later on. This PR adjusts the base streams data stream settings to use a localized data stream retention configuration to make it compatible with serverless. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

kibanamachine · 2025-01-13T08:17:07Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12743131680

Show data retention on streams In case of a policy, the name of the policy is shown (badge is clickable and leads to the edit page of the policy): <img width="524" alt="Screenshot 2024-12-12 at 20 57 36" src="https://github.com/user-attachments/assets/2664b45b-2473-49c4-b1d6-dccb8fe48d43" /> In case of DLM, the effect retention is shown: <img width="532" alt="Screenshot 2024-12-12 at 20 58 42" src="https://github.com/user-attachments/assets/07ca8086-75e2-45f8-9d71-17bd0a76ebe5" /> This is just the display piece, editing retention will be added later on. This PR adjusts the base streams data stream settings to use a localized data stream retention configuration to make it compatible with serverless. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 3515a0f)

kibanamachine · 2025-01-13T08:22:20Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.x`: - [🌊 Streams: Show data retention on stream (#204125)](#204125)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Joe Reuter <[email protected]>

Show data retention on streams In case of a policy, the name of the policy is shown (badge is clickable and leads to the edit page of the policy): <img width="524" alt="Screenshot 2024-12-12 at 20 57 36" src="https://github.com/user-attachments/assets/2664b45b-2473-49c4-b1d6-dccb8fe48d43" /> In case of DLM, the effect retention is shown: <img width="532" alt="Screenshot 2024-12-12 at 20 58 42" src="https://github.com/user-attachments/assets/07ca8086-75e2-45f8-9d71-17bd0a76ebe5" /> This is just the display piece, editing retention will be added later on. This PR adjusts the base streams data stream settings to use a localized data stream retention configuration to make it compatible with serverless. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

show data retention on stream

aa49c96

flash1293 added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 Feature:Streams This is the label for the Streams Project labels Dec 12, 2024

kibanamachine and others added 6 commits December 12, 2024 20:13

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

b4cc7a2

…fix'

Merge remote-tracking branch 'upstream/main' into flash1293/streams-d…

7a4dcd2

…ata-retention

maybe fix things

818793d

maybe fix things

de1c7e7

Merge remote-tracking branch 'upstream/main' into flash1293/streams-d…

67edb2b

…ata-retention

clean up stuff

5623c43

flash1293 marked this pull request as ready for review December 19, 2024 12:21

flash1293 requested review from a team as code owners December 19, 2024 12:21

kibanamachine added 3 commits December 19, 2024 12:24

[CI] Auto-commit changed files from 'node scripts/notice'

5948b4f

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

3614b60

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

59c24f2

…-fix'

flash1293 added 2 commits December 19, 2024 16:29

some fixes

0314451

Merge branch 'flash1293/streams-data-retention' of github.com:flash12…

ff8e23a

…93/kibana into flash1293/streams-data-retention

tonyghiani self-requested a review December 19, 2024 15:39

tonyghiani reviewed Dec 19, 2024

View reviewed changes

tonyghiani approved these changes Dec 19, 2024

View reviewed changes

fix tests

74a1355

flash1293 requested a review from a team as a code owner December 20, 2024 15:15

flash1293 added 3 commits December 29, 2024 20:30

Update kibana.jsonc

2bd1785

Merge remote-tracking branch 'upstream/main' into flash1293/streams-d…

f39cf0b

…ata-retention

fix things

86b1c52

Merge branch 'flash1293/streams-data-retention' of github.com:flash12…

d9334c3

…93/kibana into flash1293/streams-data-retention

mattkime approved these changes Dec 29, 2024

View reviewed changes

dgieselaar approved these changes Dec 30, 2024

View reviewed changes

Merge branch 'main' into flash1293/streams-data-retention

1f88212

flash1293 added 2 commits January 8, 2025 16:03

Merge remote-tracking branch 'upstream/main' into flash1293/streams-d…

db287c7

…ata-retention

fix tests

5bb5bf8

flash1293 merged commit 3515a0f into elastic:main Jan 9, 2025
8 checks passed

kibanamachine mentioned this pull request Jan 10, 2025

🌊 Fix ascendants check #206080

Merged

flash1293 added backport:version Backport to applied version labels and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 13, 2025

kibanamachine mentioned this pull request Jan 13, 2025

[8.x] 🌊 Streams: Show data retention on stream (#204125) #206393

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌊 Streams: Show data retention on stream #204125

🌊 Streams: Show data retention on stream #204125

flash1293 commented Dec 12, 2024 •

edited by kibanamachine

Loading

patpscal commented Dec 19, 2024

flash1293 commented Dec 19, 2024

tonyghiani Dec 19, 2024

flash1293 Dec 19, 2024

tonyghiani Dec 19, 2024

mattkime Dec 24, 2024 •

edited

Loading

flash1293 Dec 29, 2024

tonyghiani left a comment

mattkime left a comment

dgieselaar commented Dec 30, 2024

tonyghiani commented Dec 30, 2024

elasticmachine commented Jan 8, 2025

API count

kibanamachine commented Jan 9, 2025

kibanamachine commented Jan 9, 2025

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

🌊 Streams: Show data retention on stream #204125

🌊 Streams: Show data retention on stream #204125

Conversation

flash1293 commented Dec 12, 2024 • edited by kibanamachine Loading

patpscal commented Dec 19, 2024

flash1293 commented Dec 19, 2024

tonyghiani Dec 19, 2024

Choose a reason for hiding this comment

flash1293 Dec 19, 2024

Choose a reason for hiding this comment

tonyghiani Dec 19, 2024

Choose a reason for hiding this comment

mattkime Dec 24, 2024 • edited Loading

Choose a reason for hiding this comment

flash1293 Dec 29, 2024

Choose a reason for hiding this comment

tonyghiani left a comment

Choose a reason for hiding this comment

mattkime left a comment

Choose a reason for hiding this comment

dgieselaar commented Dec 30, 2024

tonyghiani commented Dec 30, 2024

elasticmachine commented Jan 8, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Jan 9, 2025

kibanamachine commented Jan 9, 2025

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

💚 All backports created successfully

Questions ?

flash1293 commented Dec 12, 2024 •

edited by kibanamachine

Loading

mattkime Dec 24, 2024 •

edited

Loading