[8.x] [ML] Anomaly Explorer: Enhancements for Embeddables with Selected Groups & Explorer Refactor (#203224) #204361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ups & Explorer Refactor (elastic#203224) ## Summary Fixes issues around handling groupIds in Anomaly Explorer: [elastic#198824](elastic#198824) * `UrlStateService` is now more generic, allowing for the creation of `useGlobalUrlState` and `usePageUrlState` hooks based on it. * New `useGlobalUrlState` hook: Responsible for managing global state with proper typing. * `id_badges.js` converted to typescript -> `id_badges.tsx` * The use of `maps` in the `id_badges`, `job_selector` and `job_selector_flyout` components has been removed. Now, selected group and job ids are passed directly. * Instead of manually setting the global state in `job_selector`, an `onSelectionChange` callback is now expected. In the future, the `Timeseries explorer` and `Anomaly Explorer` are expected to use a (maybe) shared context to track selected jobs easily, eliminating the need to manually update the global state for the `Timeseries explorer`. * The `AnomalyExplorerCommonStateService` now listens for URL changes to track properties derived from the URL. This replaces the `useUrlState` hook, which lacked proper typing, and serves as the single source of truth for selected jobs and groups. * The `ExplorerDashboardService`, previously a hybrid of a "service" and redux-like action handler, has been removed. The state is now managed within `state_manager` component. In the future, data like `chartsData` and `influencers` should be decoupled from `ExplorerState` and moved to individual services. 1. Fix for all issues mentioned in elastic#198824 as visible in the video: - The initial group selection now results in the correct badge being displayed. - Creating an embeddable with a selected group properly propagates the selected group instead of individual job ids. - Navigating to the Anomaly Explorer from Dashboards now correctly uses the selected group instead of individual job ids. https://github.com/user-attachments/assets/82c641e0-d930-42eb-8627-fad4bdc417f6 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit ea85f05)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
cc @rbrtj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation