[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-generative-ai` (#202848) #204468

KDKHD · 2024-12-16T18:32:30Z

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

…rity-generative-ai` (elastic#202848) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. #### 1 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/elastic-assistant-plugin` | `x-pack/solutions/security/plugins/elastic_assistant` | #### 3 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/elastic-assistant` | `x-pack/platform/packages/shared/kbn-elastic-assistant` | | `@kbn/elastic-assistant-common` | `x-pack/platform/packages/shared/kbn-elastic-assistant-common` | | `@kbn/langchain` | `x-pack/platform/packages/shared/kbn-langchain` | <details > <summary>Updated references</summary> ``` ./.buildkite/scripts/steps/code_generation/elastic_assistant_codegen.sh ./.buildkite/scripts/steps/openapi_bundling/security_solution_openapi_bundling.sh ./.eslintrc.js ./.github/codeql/codeql-config.yml ./docs/developer/plugin-list.asciidoc ./oas_docs/scripts/merge_ess_oas.js ./oas_docs/scripts/merge_serverless_oas.js ./package.json ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/.i18nrc.json ./x-pack/packages/kbn-elastic-assistant-common/README.md ./x-pack/platform/packages/shared/kbn-elastic-assistant-common/README.md ./x-pack/platform/packages/shared/kbn-elastic-assistant-common/env/README.md ./x-pack/platform/packages/shared/kbn-elastic-assistant-common/impl/capabilities/README.md ./x-pack/platform/packages/shared/kbn-elastic-assistant-common/jest.config.js ./x-pack/platform/packages/shared/kbn-elastic-assistant/README.md ./x-pack/platform/packages/shared/kbn-elastic-assistant/jest.config.js ./x-pack/platform/packages/shared/kbn-langchain/jest.config.js ./x-pack/plugins/elastic_assistant/README.md ./x-pack/plugins/security_solution/docs/openapi/README.md ./x-pack/solutions/security/plugins/elastic_assistant/README.md ./x-pack/solutions/security/plugins/elastic_assistant/jest.config.js ./x-pack/solutions/security/plugins/elastic_assistant/scripts/create_conversations_script.ts ./x-pack/solutions/security/plugins/elastic_assistant/server/__mocks__/docs_from_directory_loader.ts ./x-pack/solutions/security/plugins/elastic_assistant/server/knowledge_base/security_labs/embedding_security_in_llm_workflows.md ./x-pack/solutions/security/plugins/elastic_assistant/server/lib/attack_discovery/graphs/default_attack_discovery_graph/index.ts ./yarn.lock ``` </details><details > <summary>Updated relative paths</summary> ``` x-pack/platform/packages/shared/kbn-elastic-assistant-common/jest.config.js:21 x-pack/platform/packages/shared/kbn-elastic-assistant-common/scripts/openapi/bundle.js:8 x-pack/platform/packages/shared/kbn-elastic-assistant-common/scripts/openapi/generate.js:8 x-pack/platform/packages/shared/kbn-elastic-assistant-common/tsconfig.json:2 x-pack/platform/packages/shared/kbn-elastic-assistant/jest.config.js:21 x-pack/platform/packages/shared/kbn-elastic-assistant/tsconfig.json:15 x-pack/platform/packages/shared/kbn-elastic-assistant/tsconfig.json:2 x-pack/platform/packages/shared/kbn-langchain/jest.config.js:20 x-pack/platform/packages/shared/kbn-langchain/tsconfig.json:2 x-pack/solutions/security/plugins/elastic_assistant/jest.config.js:14 x-pack/solutions/security/plugins/elastic_assistant/scripts/create_conversations.js:8 x-pack/solutions/security/plugins/elastic_assistant/scripts/draw_graph.js:8 x-pack/solutions/security/plugins/elastic_assistant/scripts/model_evaluator.js:8 x-pack/solutions/security/plugins/elastic_assistant/tsconfig.json:13 x-pack/solutions/security/plugins/elastic_assistant/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 6de695a) # Conflicts: # .github/CODEOWNERS # oas_docs/scripts/merge_serverless_oas.js # x-pack/.i18nrc.json # x-pack/platform/packages/shared/kbn-elastic-assistant/tsconfig.json

…-fix'

github-actions · 2024-12-16T18:32:50Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

stephmilovic · 2024-12-16T18:53:06Z

@elasticmachine merge upstream

…/8.x/pr-202848

elasticmachine · 2024-12-16T20:51:11Z

💔 Build Failed

Buildkite Build
Commit: 7931a63

Failed CI Steps

Test Failures

[job] [logs] Jest Integration Tests #1 / Task cost checks detects tasks with cost definitions
[job] [logs] Jest Integration Tests #1 / Task cost checks detects tasks with cost definitions

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`integrationAssistant`	473	474	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`integrationAssistant`	880.5KB	880.5KB	+20.0B
`securitySolution`	13.5MB	13.5MB	+8.4KB
total			+8.5KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/elastic-assistant`	20	15	-5

Total ESLint disabled count

id	before	after	diff
`@kbn/elastic-assistant`	21	16	-5

History

stephmilovic · 2024-12-16T21:04:17Z

@elasticmachine merge upstream

…ana into recover/backport/8.x/pr-202848

KDKHD · 2024-12-16T21:17:49Z

Failed test is passing locally after 15c595a

gsoldevila and others added 5 commits December 15, 2024 21:43

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

d571d3c

…-fix'

Merge branch '8.x' into backport/8.x/pr-202848

2f15204

fix snapshot

3ab79d8

Merge branch '8.x' into backport/8.x/pr-202848

b75ed3a

KDKHD changed the base branch from main to 8.x December 16, 2024 18:33

KDKHD changed the title ~~Recover/backport/8.x/pr 202848~~ [8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/security-generative-ai (#202848) Dec 16, 2024

KDKHD marked this pull request as ready for review December 16, 2024 18:41

KDKHD requested a review from kibanamachine as a code owner December 16, 2024 18:41

stephmilovic added the backport label Dec 16, 2024

stephmilovic mentioned this pull request Dec 16, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/security-generative-ai #202848

Merged

stephmilovic approved these changes Dec 16, 2024

View reviewed changes

elasticmachine and others added 2 commits December 16, 2024 18:53

Merge branch '8.x' into recover/backport/8.x/pr-202848

a54ffc1

Merge branch '8.x' of github.com:elastic/kibana into recover/backport…

7931a63

…/8.x/pr-202848

KDKHD enabled auto-merge (squash) December 16, 2024 19:10

elasticmachine and others added 3 commits December 16, 2024 21:04

Merge branch '8.x' into recover/backport/8.x/pr-202848

65b4b5a

fix snapshot

15c595a

Merge branch 'recover/backport/8.x/pr-202848' of github.com:KDKHD/kib…

bb34c62

…ana into recover/backport/8.x/pr-202848

KDKHD merged commit 49f8fdd into elastic:8.x Dec 16, 2024
8 checks passed

KDKHD mentioned this pull request Dec 17, 2024

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/security-generative-ai (#202848) #204326

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-generative-ai` (#202848) #204468

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-generative-ai` (#202848) #204468

KDKHD commented Dec 16, 2024

github-actions bot commented Dec 16, 2024

stephmilovic commented Dec 16, 2024

elasticmachine commented Dec 16, 2024 •

edited

Loading

ESLint disabled line counts

Total ESLint disabled count

stephmilovic commented Dec 16, 2024

KDKHD commented Dec 16, 2024 •

edited

Loading

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/security-generative-ai (#202848) #204468

[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/security-generative-ai (#202848) #204468

Conversation

KDKHD commented Dec 16, 2024

Summary

Checklist

Identify risks

github-actions bot commented Dec 16, 2024

stephmilovic commented Dec 16, 2024

elasticmachine commented Dec 16, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

stephmilovic commented Dec 16, 2024

KDKHD commented Dec 16, 2024 • edited Loading

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-generative-ai` (#202848) #204468

[8.x] Sustainable Kibana Architecture: Move modules owned by `@elastic/security-generative-ai` (#202848) #204468

elasticmachine commented Dec 16, 2024 •

edited

Loading

KDKHD commented Dec 16, 2024 •

edited

Loading