Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ingest pipeline mgmt] Move to x-pack/platform/plugins/shared/ingest_pipelines (#204331) #204502

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

mattkime
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…pipelines (elastic#204331)

## Summary

This PR aims at relocating some of the Kibana modules (plugins and
packages) into a new folder structure, according to the _Sustainable
Kibana Architecture_ initiative.

> [!IMPORTANT]
> * We kindly ask you to:
> * Manually fix the errors in the error section below (if there are
any).
> * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the
source code (Babel and Eslint config files), and update them
appropriately.
> * Manually review
`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that
any CI pipeline customizations continue to be correctly applied after
the changed path names
> * Review all of the updated files, specially the `.ts` and `.js` files
listed in the sections below, as some of them contain relative paths
that have been updated.
> * Think of potential impact of the move, including tooling and
configuration files that can be pointing to the relocated modules. E.g.:
>     * customised eslint rules
>     * docs pointing to source code

> [!NOTE]
> * This PR has been auto-generated.
> * Any manual contributions will be lost if the 'relocate' script is
re-run.
> * Try to obtain the missing reviews / approvals before applying manual
fixes, and/or keep your changes in a .patch / git stash.
> * Please use
[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)
Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow
the steps describe
[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).

#### 1 plugin(s) are going to be relocated:

| Id | Target folder |
| -- | ------------- |
| `@kbn/ingest-pipelines-plugin` |
`x-pack/platform/plugins/shared/ingest_pipelines` |

<details >
<summary>Updated references</summary>

```
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-package-map/package-map.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./tsconfig.base.json
./tsconfig.base.type_check.json
./tsconfig.refs.json
./x-pack/.i18nrc.json
./x-pack/platform/plugins/private/transform/common/types/es_ingest_pipeline.ts
./x-pack/platform/plugins/shared/ingest_pipelines/jest.config.js
./yarn.lock
.github/CODEOWNERS
```

</details><details >
<summary>Updated relative paths</summary>

```
x-pack/platform/plugins/shared/ingest_pipelines/jest.config.js:10
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.json:11
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.json:2
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:13
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:2
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:20
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:35
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:38
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:41
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:44
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:47
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:50
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:53
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:56
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:59
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:62
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:65
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:68
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:71
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:74
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:77
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:80
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:83
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:86
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:89
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:92
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.type_check.json:95
```

</details>

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 7460dc4)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/shared/stringify_value_description.test.ts
#	x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/shared/stringify_value_description.ts
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime self-assigned this Dec 16, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

cc @mattkime

@mattkime mattkime merged commit 437b88f into elastic:8.x Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants