-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rules migration] Add Integrations column (#11387) #204639
Open
e40pud
wants to merge
14
commits into
elastic:main
Choose a base branch
from
e40pud:security/siem-migrations/11387-integrations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+424
−60
Open
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7589c75
[Rules migration] Add Integrations column (#11387)
e40pud bc2eaec
[CI] Auto-commit changed files from 'yarn openapi:generate'
kibanamachine 62c3bbd
Merge branch 'main' into security/siem-migrations/11387-integrations
e40pud 0be6f58
Merge branch 'main' into security/siem-migrations/11387-integrations
e40pud 13c18b1
Review feedback
e40pud a0a3102
Merge branch 'main' into security/siem-migrations/11387-integrations
e40pud 41e5a44
[CI] Auto-commit changed files from 'yarn openapi:generate'
kibanamachine a691602
Merge branch 'main' into security/siem-migrations/11387-integrations
e40pud ff1aa33
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine f767791
Merge branch 'main' into security/siem-migrations/11387-integrations
e40pud 3881cc2
Merge branch 'main' into security/siem-migrations/11387-integrations
e40pud ee2cb33
Review feedback
e40pud ded57e0
[CI] Auto-commit changed files from 'yarn openapi:generate'
kibanamachine 67fa11f
Merge branch 'main' into security/siem-migrations/11387-integrations
e40pud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...ity_solution/public/siem_migrations/rules/components/rules_table_columns/integrations.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React from 'react'; | ||
import type { RelatedIntegration } from '../../../../../common/api/detection_engine'; | ||
import { IntegrationsPopover } from '../../../../detections/components/rules/related_integrations/integrations_popover'; | ||
import type { RuleMigration } from '../../../../../common/siem_migrations/model/rule_migration.gen'; | ||
import * as i18n from './translations'; | ||
import type { TableColumn } from './constants'; | ||
|
||
export const createIntegrationsColumn = ({ | ||
getMigrationRuleData, | ||
}: { | ||
getMigrationRuleData: ( | ||
ruleId: string | ||
) => { relatedIntegrations?: RelatedIntegration[] } | undefined; | ||
}): TableColumn => { | ||
return { | ||
field: 'elastic_rule.integration_id', | ||
name: i18n.COLUMN_INTEGRATIONS, | ||
render: (_, rule: RuleMigration) => { | ||
const migrationRuleData = getMigrationRuleData(rule.id); | ||
const relatedIntegrations = migrationRuleData?.relatedIntegrations; | ||
if (relatedIntegrations == null || relatedIntegrations.length === 0) { | ||
return null; | ||
} | ||
return <IntegrationsPopover relatedIntegrations={relatedIntegrations} />; | ||
}, | ||
truncateText: true, | ||
width: '143px', | ||
align: 'center', | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have the {migration_id} in the path? I am confused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be
/internal/siem_migrations/rules/integrations