Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Security Solution][SIEM migrations] Onboarding UI improvements (#204320) #204719

Merged
merged 5 commits into from
Jan 8, 2025
Merged

[8.x] [Security Solution][SIEM migrations] Onboarding UI improvements (#204320) #204719

merged 5 commits into from
Jan 8, 2025

Conversation

semd
Copy link
Contributor

@semd semd commented Dec 18, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@semd
[Security Solution][SIEM migrations] Onboarding UI improvements (elas…
7cdbdca 
…tic#204320)

## Summary

Part of: elastic/security-team#10667

#### Improvements

- Implementation of the Onboarding card to create migrations using the
flyout
- Migration complete summary panel implemented
- Migration ready panel improved to detect missing resources
- Migration processing improved
- Migration missing resources panel implemented
- All migration panels and refactored to be reusable by translation
table using the
- `RuleMigrationDataInputWrapper` implemented to reuse the Flyout from
the translation table
- Request poll interval increased from 5 to 10 seconds due to event loop
usage.

> [!NOTE]
> This feature needs `siemMigrationsEnabled` experimental flag enabled
to work.

## Screenshots

Lookups input

![Lookups](https://github.com/user-attachments/assets/73f91e10-7252-44d1-ab0d-89880c78a2b3)

Translation "complete" panel
![Translation
summary](https://github.com/user-attachments/assets/6fbb451d-c7b3-4a23-a2df-083c91948cbd)

Translation "created" panel (w/ and w/o missing macros)
![Ready
panels](https://github.com/user-attachments/assets/f8334af2-ccc1-473c-8548-772a9d656aba)

Translation processing (preparing)
![preparing
panel](https://github.com/user-attachments/assets/0156caba-c6c9-43c1-881a-8bf631f3a8ab)

Translation processing (translating)
![translating
panel](https://github.com/user-attachments/assets/db523e4b-4858-482f-bfe9-1e36f715fa20)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 303eee8)
@semd semd requested a review from kibanamachine as a code owner December 18, 2024 11:05
@semd semd added the backport label Dec 18, 2024
@semd semd enabled auto-merge (squash) December 18, 2024 11:05
@semd semd mentioned this pull request Dec 18, 2024
Merged
@semd
Copy link
Contributor Author

semd commented Dec 18, 2024

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Jan 8, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@semd semd merged commit 4b931d0 into elastic:8.x Jan 8, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / FormFields renders correctly
  • [job] [logs] Jest Tests #17 / OutputHealth should render output health component when degraded
  • [job] [logs] Jest Tests #17 / Test packages All test packages should be valid (node scripts/verify_test_packages)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6505 6516 +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 19.2MB 19.2MB +13.0KB

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e40pud e40pud e40pud approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semd @elasticmachine @e40pud @kibanamachine