[embeddable] remove embeddable factory methods from setup and start API #204797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
nreese
added
Team:Presentation
ThomThomson
approved these changes
Dec 19, 2024
| @@ -15,7 +15,7 @@ import { injectBaseEmbeddableInput } from './migrate_base_input'; | |||
| export const getInjectFunction = (embeddables: CommonEmbeddableStartContract) => { | |||
| return (state: EmbeddableStateWithType, references: SavedObjectReference[]) => { | |||
| const enhancements = state.enhancements || {}; | |||
| const factory = embeddables.getEmbeddableFactory(state.type); | |||
| const factory = embeddables.getEmbeddableFactory?.(state.type); | |||
There was a problem hiding this comment.
Looks like this function was marked optional in CommonEmbeddableStartContract, but that type isn't used in the client-side definition of EmbeddableStart. I understand this function was removed from the clientside version, but is there a reason it needed to be marked optional in the serverside one?
There was a problem hiding this comment.
Both client and server use inject so I typed getEmbeddableFactory as optional since its not provided by the client.
| private appList?: ReadonlyMap<string, PublicAppInfo>; | ||
| private appListSubscription?: Subscription; | ||
| private enhancementsRegistry = new EnhancementsRegistry(); |
There was a problem hiding this comment.
Good call to move the registry code into its own file rather than clogging up the plugin.
| }; | ||
|
|
||
| const getAllMigrationsFn = () => | ||
| getAllMigrations( | ||
| Array.from(this.embeddableFactories.values()), | ||
| Array.from(this.enhancements.values()), | ||
| [], |
There was a problem hiding this comment.
Nice temporary solution here
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miloszmarcinkowski
approved these changes
Dec 19, 2024
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
|
@elasticmachine merge upstream |
⏳ Build in-progress
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2024
…PI (elastic#204797) Part of embeddable rebuild cleanup. PR removes legacy embeddable factory registration APIs. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 3b61e7b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2024
…tart API (#204797) (#204993) # Backport This will backport the following commits from `main` to `8.x`: - [[embeddable] remove embeddable factory methods from setup and start API (#204797)](#204797) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T18:19:48Z","message":"[embeddable] remove embeddable factory methods from setup and start API (#204797)\n\nPart of embeddable rebuild cleanup. PR removes legacy embeddable factory\r\nregistration APIs.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3b61e7bea7408e586faa4be6464e963b50385896","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[embeddable] remove embeddable factory methods from setup and start API","number":204797,"url":"https://github.com/elastic/kibana/pull/204797","mergeCommit":{"message":"[embeddable] remove embeddable factory methods from setup and start API (#204797)\n\nPart of embeddable rebuild cleanup. PR removes legacy embeddable factory\r\nregistration APIs.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3b61e7bea7408e586faa4be6464e963b50385896"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204797","number":204797,"mergeCommit":{"message":"[embeddable] remove embeddable factory methods from setup and start API (#204797)\n\nPart of embeddable rebuild cleanup. PR removes legacy embeddable factory\r\nregistration APIs.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3b61e7bea7408e586faa4be6464e963b50385896"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of embeddable rebuild cleanup. PR removes legacy embeddable factory registration APIs.