Fix resolve index API to not throw 500 when encountering no_such_remote_cluster_exception
#204802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:Data Views
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
reviewed
Dec 19, 2024
| }, | ||
| }; | ||
|
|
||
| describe('preview_scripted_field route', () => { |
There was a problem hiding this comment.
Suggested change
| describe('preview_scripted_field route', () => { | |
| describe('resolve_index route', () => { |
There was a problem hiding this comment.
Can we also extend the integration tests with this case?
test/api_integration/apis/data_views/resolve_index/resolve_index.ts
There was a problem hiding this comment.
Added in 322412c. (We already had a test for should return 404 for an exact match index but I added one for should return 200 for a search for indices with wildcard.)
jughosta
approved these changes
Dec 19, 2024
test/api_integration/apis/data_views/resolve_index/resolve_index.ts
Outdated
Show resolved
Hide resolved
…ex.ts Co-authored-by: Julia Rechkunova <[email protected]>
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @lukasolson |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2024
…ote_cluster_exception` (elastic#204802) ## Summary Fixes elastic#197747. Updates the `/internal/index-pattern-management/resolve_index/{query}` route to properly handle `no_such_remote_cluster_exception` and return `404` rather than `500` server error. Adds unit tests for the route handler. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Julia Rechkunova <[email protected]> (cherry picked from commit 0952f6e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2024
…no_such_remote_cluster_exception` (#204802) (#205016) # Backport This will backport the following commits from `main` to `8.x`: - [Fix resolve index API to not throw 500 when encountering `no_such_remote_cluster_exception` (#204802)](#204802) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lukas Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T21:55:29Z","message":"Fix resolve index API to not throw 500 when encountering `no_such_remote_cluster_exception` (#204802)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/197747.\r\n\r\nUpdates the `/internal/index-pattern-management/resolve_index/{query}`\r\nroute to properly handle `no_such_remote_cluster_exception` and return\r\n`404` rather than `500` server error.\r\n\r\nAdds unit tests for the route handler.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"0952f6e0f52771b3503c9ddd2afd793d8ed86709","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data Views","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"Fix resolve index API to not throw 500 when encountering `no_such_remote_cluster_exception`","number":204802,"url":"https://github.com/elastic/kibana/pull/204802","mergeCommit":{"message":"Fix resolve index API to not throw 500 when encountering `no_such_remote_cluster_exception` (#204802)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/197747.\r\n\r\nUpdates the `/internal/index-pattern-management/resolve_index/{query}`\r\nroute to properly handle `no_such_remote_cluster_exception` and return\r\n`404` rather than `500` server error.\r\n\r\nAdds unit tests for the route handler.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"0952f6e0f52771b3503c9ddd2afd793d8ed86709"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204802","number":204802,"mergeCommit":{"message":"Fix resolve index API to not throw 500 when encountering `no_such_remote_cluster_exception` (#204802)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/197747.\r\n\r\nUpdates the `/internal/index-pattern-management/resolve_index/{query}`\r\nroute to properly handle `no_such_remote_cluster_exception` and return\r\n`404` rather than `500` server error.\r\n\r\nAdds unit tests for the route handler.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"0952f6e0f52771b3503c9ddd2afd793d8ed86709"}}]}] BACKPORT--> Co-authored-by: Lukas Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #197747.
Updates the
/internal/index-pattern-management/resolve_index/{query}route to properly handleno_such_remote_cluster_exceptionand return404rather than500server error.Adds unit tests for the route handler.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.