Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES body removal] @elastic/appex-sharedux #204874

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 19, 2024

Summary

Attempt to remove the deprecated body in the ES client.

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@afharo afharo self-assigned this Dec 19, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @afharo

@afharo afharo marked this pull request as ready for review December 19, 2024 15:23
@afharo afharo requested a review from a team as a code owner December 19, 2024 15:23
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting the tests 🟢

@afharo afharo merged commit 84fcda0 into elastic:main Dec 19, 2024
9 checks passed
@afharo afharo deleted the esclient/remove-deprecated-body/elastic/appex-sharedux branch December 19, 2024 15:55
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12416195147

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2024
## Summary

Attempt to remove the deprecated `body` in the ES client.

(cherry picked from commit 84fcda0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
…0; (#204874) (#204969)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES `body` removal] `@elastic/appex-sharedux`
(#204874)](#204874)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T15:55:02Z","message":"[ES
`body` removal] `@elastic/appex-sharedux` (#204874)\n\n##
Summary\n\nAttempt to remove the deprecated `body` in the ES
client.","sha":"84fcda021be1d71018fa77005837da7e932c6d7f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[ES
`body` removal]
`@elastic/appex-sharedux`","number":204874,"url":"https://github.com/elastic/kibana/pull/204874","mergeCommit":{"message":"[ES
`body` removal] `@elastic/appex-sharedux` (#204874)\n\n##
Summary\n\nAttempt to remove the deprecated `body` in the ES
client.","sha":"84fcda021be1d71018fa77005837da7e932c6d7f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204874","number":204874,"mergeCommit":{"message":"[ES
`body` removal] `@elastic/appex-sharedux` (#204874)\n\n##
Summary\n\nAttempt to remove the deprecated `body` in the ES
client.","sha":"84fcda021be1d71018fa77005837da7e932c6d7f"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
## Summary

Attempt to remove the deprecated `body` in the ES client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants