Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Attack discovery] Update Attack Discovery evaluation prompts #205002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security Solution] [Attack discovery] Update Attack Discovery evaluation prompts #205002

wants to merge 1 commit into from
+5 −5

Conversation

susan-shu-c
Copy link
Member

[Security Solution] [Attack discovery] Update Attack Discovery evaluation prompts

This PR updates prompts used to evaluate the initial outputs of Attack Discovery.
Only text was changed.

@susan-shu-c susan-shu-c requested a review from a team as a code owner December 19, 2024 19:47
@susan-shu-c susan-shu-c added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI labels Dec 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@susan-shu-c susan-shu-c added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.18.0 labels Dec 19, 2024
@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / getDefaultPromptTemplate returns the expected prompt template
  • [job] [logs] Jest Tests #14 / getDefaultPromptTemplate returns the expected prompt template

andrew-goldstein
andrew-goldstein approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @susan-shu-c for these improvements to the evaluation prompts! 🙏
✅ Desk tested locally
LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susan-shu-c @elasticmachine @andrew-goldstein