Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Delete deprecated avatars #205448

Merged
merged 3 commits into from
Jan 7, 2025
Merged

[chore] Delete deprecated avatars #205448

merged 3 commits into from
Jan 7, 2025

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Jan 2, 2025 •
edited by kibanamachine
Loading

Summary

As titled. Delete deprecated avatars, replace stray usage.

Screenshot 2025-01-02 at 4 38 33 PM

@clintandrewhall clintandrewhall added review release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 2, 2025
@clintandrewhall clintandrewhall requested review from a team as code owners January 2, 2025 21:38
@botelastic botelastic bot added the Team:Obs AI Assistant Observability AI Assistant label Jan 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@clintandrewhall clintandrewhall enabled auto-merge (squash) January 2, 2025 21:39
@clintandrewhall clintandrewhall merged commit 292111b into elastic:main Jan 7, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12660297046

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistant 117 116 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityAIAssistant 379 377 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 295.2KB 295.2KB -8.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observabilityAIAssistant 30 29 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 48.1KB 47.4KB -693.0B
Unknown metric groups

API count

id before after diff
observabilityAIAssistant 381 379 -2

ESLint disabled line counts

id before after diff
@kbn/elastic-assistant 15 14 -1

References to deprecated APIs

id before after diff
observabilityAIAssistantApp 2 0 -2

Total ESLint disabled count

id before after diff
@kbn/elastic-assistant 16 15 -1

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- Reapply "[Response Ops][Alerting] Backfill actions schema changes for intermediate release (#204657)
- [Streams] Dashboard linking (#204309)
- Add ".reindexed-v8-" prefix to the valid prefixes list (#204819)
- [AVC Banner] Updates the AVC Banner for 2025 (#205467)
- [ML] DFA: Fix layout of job status in expanded row. (#204978)
- [Stack Connectors][Microsoft Defender] Adds new connector for Microsoft Defender for Endpoint (#203183)
- remove outstanding testing-library/react-hooks usages (#205307)
- Conditionally add agentless index permissions (#203810)

Manual backport

To create the backport manually run:

node scripts/backport --pr 205448

Questions ?

Please refer to the Backport tool documentation

crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
@clintandrewhall @crespocarlos
[chore] Delete deprecated avatars (elastic#205448)
72b5d70 
## Summary

As titled.  Delete deprecated avatars, replace stray usage.

<img width="1021" alt="Screenshot 2025-01-02 at 4 38 33 PM"
src="https://github.com/user-attachments/assets/01e8045c-5209-4926-a5da-f04aa65ac76e"
/>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 8, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205448 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205448 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205448 locally

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@clintandrewhall @CAWilson94
[chore] Delete deprecated avatars (elastic#205448)
aef03d6 
## Summary

As titled.  Delete deprecated avatars, replace stray usage.

<img width="1021" alt="Screenshot 2025-01-02 at 4 38 33 PM"
src="https://github.com/user-attachments/assets/01e8045c-5209-4926-a5da-f04aa65ac76e"
/>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205448 locally

@clintandrewhall clintandrewhall mentioned this pull request Jan 14, 2025
Merged
@clintandrewhall
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Jan 14, 2025
@clintandrewhall
[chore] Delete deprecated avatars (elastic#205448)
840a742 
## Summary

As titled.  Delete deprecated avatars, replace stray usage.

<img width="1021" alt="Screenshot 2025-01-02 at 4 38 33 PM"
src="https://github.com/user-attachments/assets/01e8045c-5209-4926-a5da-f04aa65ac76e"
/>

(cherry picked from commit 292111b)

# Conflicts:
#	x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/assistant_animated_icon.tsx
#	x-pack/platform/plugins/shared/observability_solution/observability_ai_assistant/public/components/assistant_avatar.tsx
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

clintandrewhall added a commit that referenced this pull request Jan 15, 2025
@clintandrewhall
[8.x] [chore] Delete deprecated avatars (#205448) (#206532)
383564e 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[chore] Delete deprecated avatars
(#205448)](#205448)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Clint Andrew
Hall","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T22:21:21Z","message":"[chore]
Delete deprecated avatars (#205448)\n\n## Summary\r\n\r\nAs titled.
Delete deprecated avatars, replace stray usage.\r\n\r\n<img
width=\"1021\" alt=\"Screenshot 2025-01-02 at 4 38
33 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/01e8045c-5209-4926-a5da-f04aa65ac76e\"\r\n/>","sha":"292111b0d694254cabc23df5751d2a9007794e91","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","backport
missing","v9.0.0","backport:prev-minor","ci:build-storybooks","Team:Obs
AI
Assistant"],"number":205448,"url":"https://github.com/elastic/kibana/pull/205448","mergeCommit":{"message":"[chore]
Delete deprecated avatars (#205448)\n\n## Summary\r\n\r\nAs titled.
Delete deprecated avatars, replace stray usage.\r\n\r\n<img
width=\"1021\" alt=\"Screenshot 2025-01-02 at 4 38
33 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/01e8045c-5209-4926-a5da-f04aa65ac76e\"\r\n/>","sha":"292111b0d694254cabc23df5751d2a9007794e91"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205448","number":205448,"mergeCommit":{"message":"[chore]
Delete deprecated avatars (#205448)\n\n## Summary\r\n\r\nAs titled.
Delete deprecated avatars, replace stray usage.\r\n\r\n<img
width=\"1021\" alt=\"Screenshot 2025-01-02 at 4 38
33 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/01e8045c-5209-4926-a5da-f04aa65ac76e\"\r\n/>","sha":"292111b0d694254cabc23df5751d2a9007794e91"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 15, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@clintandrewhall @viduni94
[chore] Delete deprecated avatars (elastic#205448)
a3396c1 
## Summary

As titled.  Delete deprecated avatars, replace stray usage.

<img width="1021" alt="Screenshot 2025-01-02 at 4 38 33 PM"
src="https://github.com/user-attachments/assets/01e8045c-5209-4926-a5da-f04aa65ac76e"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@angorayc angorayc angorayc approved these changes

@neptunian neptunian neptunian approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:build-storybooks release_note:skip Skip the PR/issue when compiling release notes review Team:Obs AI Assistant Observability AI Assistant v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clintandrewhall @elasticmachine @kibanamachine @neptunian @angorayc @stephmilovic