Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Streams] Dashboard linking (#204309) #205842

Merged
merged 7 commits into from
Jan 10, 2025
Merged

[8.x] [Streams] Dashboard linking (#204309) #205842

merged 7 commits into from
Jan 10, 2025

Conversation

dgieselaar
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@dgieselaar
[Streams] Dashboard linking (elastic#204309)
0592b3f 
Links dashboard to Streams.

Changes:
- Introduces `IndexStorageAdapter` to manage ES indices - see
https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md
for motivation
- Introduces `AssetClient` and `AssetService` to manage asset links with
`IndexStorageAdapter`
- `RepositorySupertestClient` to make it easier to use
`@kbn/server-route-repository` with FTR tests
- refactors related to above changes

---------

Co-authored-by: Chris Cowan <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 28414ce)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/tsconfig.json
@dgieselaar dgieselaar enabled auto-merge (squash) January 8, 2025 08:58
@dgieselaar dgieselaar mentioned this pull request Jan 8, 2025
Merged
@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

There are no new commits on the base branch.

@flash1293
Copy link
Contributor

Seems like this was flakiness, trying again

tonyghiani
tonyghiani approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was good already but manually created backports require a manual review check, approved now.

@dgieselaar dgieselaar removed the request for review from kibanamachine January 10, 2025 12:20
@dgieselaar dgieselaar merged commit bb9d120 into elastic:8.x Jan 10, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 178 200 +22

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
streams 9 13 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 184.0KB 192.2KB +8.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
streams 2 8 +6
Unknown metric groups

API count

id before after diff
streams 9 13 +4

References to deprecated APIs

id before after diff
streamsApp 0 2 +2

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgieselaar @elasticmachine @flash1293 @tonyghiani @kibanamachine