-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops] [Rule Form] Add new flyout to rule form library, responsive design and illustration to rule form page #205977
Closed
+11,160
−131,220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:enhancement
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v9.0.0
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
backport:version
Backport to applied version labels
v8.18.0
labels
Jan 8, 2025
Pinging @elastic/response-ops (Team:ResponseOps) |
botelastic
bot
added
Team:Fleet
Team label for Observability Data Collection Fleet team
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
labels
Jan 9, 2025
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Pinging @elastic/fleet (Team:Fleet) |
Bad rebase, closing |
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
release_note:enhancement
Team:Fleet
Team label for Observability Data Collection Fleet team
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is DEPENDENT on #205944
Because we use a fork-and-pull contribution structure at Elastic, Github is not able to base this PR off the correct branch without opening the PR outside the main Kibana repo. Please use manual diffing tools to review this code until #205944 merges
Summary
Part of #195211
Non-User Facing Changes
@kbn/response-ops-rule-form
. It is not yet actually user-facing anywhere in the application, this will be done in a second PR.Screenshots
User-Facing Changes
These changes were added to the existing full page rule form to minimize the amount of code differences between the flyout and the full page
Screenshot
Screenshot
Testing
To test the new flyout, edit
packages/response-ops/rule_form/src/create_rule_form.tsx
andpackages/response-ops/rule_form/src/edit_rule_form.tsx
so that they render<RuleFlyout>
instead of<RulePage>
.Use this diff block
Still Todo
Checklist