-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Add a default "All logs" temporary data view in the Observability Solution view #205991
Merged
davismcphee
merged 33 commits into
elastic:main
from
davismcphee:discover-ad-hoc-data-views-extension
Jan 29, 2025
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
8cd7089
Initial getDefaultAdHocDataViews extension
davismcphee c146fac
Finish initial implementation
davismcphee 79f0ec0
Fix types
davismcphee 13db01c
Add useDefaultAdHocDataViews hook
davismcphee deae60b
Move default profile ad hoc data views to internal state
davismcphee 0e8f21c
Fix types and tests
davismcphee 3f9bdba
Fix broken test
davismcphee 255fff2
Fix broken test
davismcphee 7770cc0
Update default o11y logs data view
davismcphee f79ef92
Fix Jest test
davismcphee f3d14f0
Remove CCS special handling
davismcphee dfdbf94
Update implementation and add tests
davismcphee e45a53a
Fix profile data view fields loading, and clean up resolve_data_view
davismcphee a411d60
Duplicate default profile data view on saved search change
davismcphee c3d1bd6
Add Jest test
davismcphee 5ac5cfc
Add more tests
davismcphee 1f372b2
Fix missing fields when changing data view
davismcphee c430307
Add functional tests
davismcphee 3db6ffb
Fix test skips
davismcphee c665e5c
Updating comments
davismcphee 76e11f4
Merge branch 'main' into discover-ad-hoc-data-views-extension
davismcphee c2328cd
Merge branch 'main' into discover-ad-hoc-data-views-extension
davismcphee 0d803a7
Use Discover session title instead of 'copy' for cloned default profi…
davismcphee ad21e3d
Clean up logic around no data page check
davismcphee 0b7d4ee
Allow overwriting default profile data views with spec in location state
davismcphee ebd3cb6
Update filter references when saving session with default profiel dat…
davismcphee c4d8168
Fix type
davismcphee 751f366
Add support for showing managed data views in the data view picker
davismcphee af6171f
Merge branch 'main' into discover-ad-hoc-data-views-extension
davismcphee 641c013
Fix Jest tests
davismcphee ed79553
Merge branch 'main' into discover-ad-hoc-data-views-extension
davismcphee 991548e
Allow sidebar URL tracking for default profile data views
davismcphee 7306fc1
Add test for getDefaultAdHocDataViews
davismcphee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use Discover session title instead of 'copy' for cloned default profi…
…le data views
- Loading branch information
commit 0d803a7d1939b3d673456064921c6c4406ad79c6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add
managed
flag to this data view (and exclude it when saving a session)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the
managed
flag we add to integration and system created SOs? If so, it sounds like a good idea (would be nice to show "Managed" in the data view selector too), but it doesn't seem like data views support that currently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, seems to be fitting here. We could address it separately.
cc @kertal regarding adding "Managed" to data views.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see what I can do here in the meantime. While supporting managed data views is likely too much for this PR and 9.0 FF timeframe, I may be able to "mark" it some way similar to ES|QL data views so we can at least differentiate them in the data view picker. I agree with your other comment about seeing "Temporary" by default and would like to fix that if we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So without fully supporting managed data views, I made it so we can still show specific data views as "Managed" in the picker the same way we handle "Temporary": 751f366. I think this would at least make the UX less confusing for users. WDYT?

I also fixed showing ad hoc data view in the mobile data view picker since it seems that was never supported before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!