Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streams] Fix broken image usage #206258

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[Streams] Fix broken image usage #206258

merged 2 commits into from
Jan 10, 2025

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Jan 10, 2025 •
edited by kibanamachine
Loading

📓 Summary

Fixes a missing referenced image after merging #204793

@tonyghiani tonyghiani requested a review from a team as a code owner January 10, 2025 11:22
@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Feature:Streams This is the label for the Streams Project backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 10, 2025
@tonyghiani tonyghiani changed the title fix(streams): broken image usage [Streams] Fix broken image usage Jan 10, 2025
@tonyghiani tonyghiani enabled auto-merge (squash) January 10, 2025 11:25
@afharo afharo mentioned this pull request Jan 10, 2025
Merged
4 tasks
@tonyghiani tonyghiani merged commit 3d82bb5 into elastic:main Jan 10, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12710186535

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [abf00ee]

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- 🌊 Stream overview page (#204079)

Manual backport

To create the backport manually run:

node scripts/backport --pr 206258

Questions ?

Please refer to the Backport tool documentation

@tonyghiani tonyghiani deleted the fix-missing-asset branch January 10, 2025 13:22
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@tonyghiani @CAWilson94
[Streams] Fix broken image usage (elastic#206258)
b02fe6c 
## 📓 Summary

Fixes a missing referenced image after merging
elastic#204793
@tonyghiani tonyghiani added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 13, 2025
@tonyghiani
Copy link
Contributor Author

This PR is backported as part of [8.x] [Streams 🌊] Stream enrichment processors management (#204793) given the fix was made for a merging race-condition between branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyghiani @kibanamachine @elasticmachine @Kerry350