[Discover] Remove redundant data fetching when hiding/showing the histogram/chart #206389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
1 similar comment
|
/ci |
kertal
changed the title
kertal
added
Feature:Discover
|
/ci |
|
/ci |
1 similar comment
|
/ci |
|
/ci |
7 tasks
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
/ci |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7724[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed. |
|
/ci |
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @kertal |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 17, 2025
…togram/chart (elastic#206389) Since the timerange in Discover of the main request is stable we don't need to trigger a main fetch for all data when the histogram/chart is being hidden/displayed, unless it's necessary to get the data (e.g. when the histogram/chart was hiden when a discover session was being loaded) (cherry picked from commit a042747)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 17, 2025
…he histogram/chart (#206389) (#207051) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Remove redundant data fetching when hiding/showing the histogram/chart (#206389)](#206389) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-17T10:49:37Z","message":"[Discover] Remove redundant data fetching when hiding/showing the histogram/chart (#206389)\n\nSince the timerange in Discover of the main request is stable we don't need to trigger a main fetch for all data when the histogram/chart is being hidden/displayed, unless it's necessary to get the data (e.g. when the histogram/chart was hiden when a discover session was being loaded)","sha":"a04274723ef64182df96d37d134cc645e20571ee","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Discover","performance","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[Discover] Remove redundant data fetching when hiding/showing the histogram/chart","number":206389,"url":"https://github.com/elastic/kibana/pull/206389","mergeCommit":{"message":"[Discover] Remove redundant data fetching when hiding/showing the histogram/chart (#206389)\n\nSince the timerange in Discover of the main request is stable we don't need to trigger a main fetch for all data when the histogram/chart is being hidden/displayed, unless it's necessary to get the data (e.g. when the histogram/chart was hiden when a discover session was being loaded)","sha":"a04274723ef64182df96d37d134cc645e20571ee"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206389","number":206389,"mergeCommit":{"message":"[Discover] Remove redundant data fetching when hiding/showing the histogram/chart (#206389)\n\nSince the timerange in Discover of the main request is stable we don't need to trigger a main fetch for all data when the histogram/chart is being hidden/displayed, unless it's necessary to get the data (e.g. when the histogram/chart was hiden when a discover session was being loaded)","sha":"a04274723ef64182df96d37d134cc645e20571ee"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 17, 2025
…togram/chart (elastic#206389) Since the timerange in Discover of the main request is stable we don't need to trigger a main fetch for all data when the histogram/chart is being hidden/displayed, unless it's necessary to get the data (e.g. when the histogram/chart was hiden when a discover session was being loaded)
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 21, 2025
…togram/chart (elastic#206389) Since the timerange in Discover of the main request is stable we don't need to trigger a main fetch for all data when the histogram/chart is being hidden/displayed, unless it's necessary to get the data (e.g. when the histogram/chart was hiden when a discover session was being loaded)
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…togram/chart (elastic#206389) Since the timerange in Discover of the main request is stable we don't need to trigger a main fetch for all data when the histogram/chart is being hidden/displayed, unless it's necessary to get the data (e.g. when the histogram/chart was hiden when a discover session was being loaded)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With #204694 being merged, fixing the issue that the requests for results of the data table and the chart can have different time ranges, we now no longer need to fetch all data data when the chart visibility is toggled in Discover. We can now fetch it when needed, the Lens embeddable automatically takes care of it in this case. This simplifies the logic and removes and resolves another issue of additional redundant data fetching when using ES|QL in Discover.
This is how it's supposed to work. When showing a histogram that's hidden, the timerange of the recent request should be used to get the data, also when hiding the histogram, no data should be requested. With the change in #204694 this is possible and it's implemented this way now
Checklist