[inference] add support for modelName parameter #206706
Merged
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
pgayvallet
added
release_note:skip
|
Pinging @elastic/appex-ai-infra (Team:AI Infra) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
|
sorenlouv
approved these changes
Jan 15, 2025
legrego
approved these changes
Jan 15, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 16, 2025
## Summary Related to elastic#206710 Add a `modelName` parameter to the chatComplete inference API, and wire it accordingly on all adapters. That parameter can be used to override the default model specified by the connector, at call time. (cherry picked from commit e0092ad)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 16, 2025
) # Backport This will backport the following commits from `main` to `8.x`: - [[inference] add support for modelName parameter (#206706)](#206706) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pierre Gayvallet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T09:12:14Z","message":"[inference] add support for modelName parameter (#206706)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/206710\r\n\r\nAdd a `modelName` parameter to the chatComplete inference API, and wire\r\nit accordingly on all adapters.\r\n\r\nThat parameter can be used to override the default model specified by\r\nthe connector, at call time.","sha":"e0092ad2fdb9f449c3033aab90228b2574eb7a36","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","Team:AI Infra","v8.18.0"],"title":"[inference] add support for modelName parameter","number":206706,"url":"https://github.com/elastic/kibana/pull/206706","mergeCommit":{"message":"[inference] add support for modelName parameter (#206706)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/206710\r\n\r\nAdd a `modelName` parameter to the chatComplete inference API, and wire\r\nit accordingly on all adapters.\r\n\r\nThat parameter can be used to override the default model specified by\r\nthe connector, at call time.","sha":"e0092ad2fdb9f449c3033aab90228b2574eb7a36"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206706","number":206706,"mergeCommit":{"message":"[inference] add support for modelName parameter (#206706)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/206710\r\n\r\nAdd a `modelName` parameter to the chatComplete inference API, and wire\r\nit accordingly on all adapters.\r\n\r\nThat parameter can be used to override the default model specified by\r\nthe connector, at call time.","sha":"e0092ad2fdb9f449c3033aab90228b2574eb7a36"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Pierre Gayvallet <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary Related to elastic#206710 Add a `modelName` parameter to the chatComplete inference API, and wire it accordingly on all adapters. That parameter can be used to override the default model specified by the connector, at call time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #206710
Add a
modelNameparameter to the chatComplete inference API, and wire it accordingly on all adapters.That parameter can be used to override the default model specified by the connector, at call time.