Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Cases] Skipped tests no floating promises fixes #206718

Merged
merged 5 commits into from
Jan 17, 2025
+13 −12
Merged

[ResponseOps][Cases] Skipped tests no floating promises fixes #206718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ca9581
skipped test after no-floating-promises fixes
georgianaonoleata1904 Jan 14, 2025
1a55f2b
fixed custom fields related tests
georgianaonoleata1904 Jan 15, 2025
7726b92
Merge branch 'main' into skipped-tests-no-floating-promises-fixes
georgianaonoleata1904 Jan 15, 2025
8b68fbd
un-skipped tests in serverless
georgianaonoleata1904 Jan 15, 2025
03a88f8
Merge branch 'main' into skipped-tests-no-floating-promises-fixes
georgianaonoleata1904 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

// https://github.com/elastic/kibana/pull/190690
// fails after missing `awaits` were added
describe.skip('View case', () => {
describe('View case', () => {
describe('page', () => {
createOneCaseBeforeDeleteAllAfter(getPageObject, getService);

Expand Down Expand Up @@ -581,12 +581,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
expect(await commentArea.getVisibleText()).to.be('Test comment from automation');
});

/**
* There is this bug https://github.com/elastic/kibana/issues/157280
* where this test randomly reproduces thus making the test flaky.
* Skipping for now until we fix it.
*/
it.skip('should persist the draft of new comment while description is updated', async () => {
it('should persist the draft of new comment while description is updated', async () => {
let commentArea = await find.byCssSelector(
'[data-test-subj="add-comment"] textarea.euiMarkdownEditorTextArea'
);
Expand Down Expand Up @@ -787,6 +782,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

await cases.common.selectSeverity(CaseSeverity.MEDIUM);

await header.waitUntilLoadingHasFinished();

await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']);

await header.waitUntilLoadingHasFinished();
Expand Down Expand Up @@ -1277,7 +1274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
await header.waitUntilLoadingHasFinished();
});

afterEach(async () => {
after(async () => {
await cases.api.deleteAllCases();
});

Expand Down
6 changes: 4 additions & 2 deletions x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

// https://github.com/elastic/kibana/pull/190690
// fails after missing `awaits` were added
describe.skip('Case View', function () {
describe('Case View', function () {
before(async () => {
await svlCommonPage.loginWithPrivilegedRole();
});
Expand Down Expand Up @@ -235,6 +235,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

await cases.common.selectSeverity(CaseSeverity.MEDIUM);

await header.waitUntilLoadingHasFinished();

await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']);

await header.waitUntilLoadingHasFinished();
Expand Down Expand Up @@ -272,7 +274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
});

// FLAKY
describe.skip('Lens visualization', () => {
describe('Lens visualization', () => {
before(async () => {
await cases.testResources.installKibanaSampleData('logs');
await createAndNavigateToCase(getPageObject, getService, owner);
Expand Down
6 changes: 4 additions & 2 deletions x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

// https://github.com/elastic/kibana/pull/190690
// fails after missing `awaits` were added
describe.skip('Case View', function () {
describe('Case View', function () {
before(async () => {
await svlCommonPage.loginWithPrivilegedRole();
});
Expand Down Expand Up @@ -235,6 +235,8 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {

await cases.common.selectSeverity(CaseSeverity.MEDIUM);

await header.waitUntilLoadingHasFinished();

await cases.common.changeCaseStatusViaDropdownAndVerify(CaseStatuses['in-progress']);

await header.waitUntilLoadingHasFinished();
Expand Down Expand Up @@ -272,7 +274,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
});

// FLAKY
describe.skip('Lens visualization', () => {
describe('Lens visualization', () => {
before(async () => {
await cases.testResources.installKibanaSampleData('logs');
await createAndNavigateToCase(getPageObject, getService, owner);
Expand Down
Loading