[Security Solution] Adds prebuilt rule customization integration tests #207016
+910
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumlee
added
test
release_note:skip
12 tasks
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
💚 Build Succeeded
Metrics [docs]
History
cc @dplumlee |
|
@elasticmachine merge upstream |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7919[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/prebuilt_rule_customization/customization_enabled/configs/ess.config.ts: 100/100 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7920[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/prebuilt_rule_customization/customization_enabled/configs/serverless.config.ts: 95/100 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7927[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/prebuilt_rule_customization/customization_enabled/configs/serverless.config.ts: 74/100 tests passed. |
banderror
reviewed
Feb 24, 2025
Comment on lines
+40
to
+48
| beforeEach(async () => { | ||
| await createPrebuiltRuleAssetSavedObjects(es, [ruleAsset]); | ||
| await installPrebuiltRules(es, supertest); | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| await deleteAllRules(supertest, log); | ||
| await deleteAllPrebuiltRuleAssets(es, log); | ||
| }); |
There was a problem hiding this comment.
Test cleanup should be done in beforeEach to avoid situations when an afterEach fails for whatever reason for a test and then the next test starts after that and assumes that the state is clean, but it's not.
Comment on lines
+314
to
+323
| describe('query rule fields', () => { | ||
| beforeEach(async () => { | ||
| await createPrebuiltRuleAssetSavedObjects(es, [ruleAsset]); | ||
| await installPrebuiltRules(es, supertest); | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| await deleteAllRules(supertest, log); | ||
| await deleteAllPrebuiltRuleAssets(es, log); | ||
| }); |
There was a problem hiding this comment.
Why we keep deleting and creating prebuilt rule assets in every test? Rule assets are read-only objects and we could pre-create all the assets needed for all the tests in this file, and do it once.
Comment on lines
+325
to
+330
| it('query field', async () => { | ||
| const { body } = await securitySolutionApi | ||
| .patchRule({ | ||
| body: { rule_id: 'rule_1', query: 'event.action: *' }, | ||
| }) | ||
| .expect(200); |
There was a problem hiding this comment.
Why do we only test the PATCH endpoint? We should have tests for the PUT endpoint as well.
Comment on lines
+332
to
+333
| expect(body.rule_source.is_customized).toEqual(true); | ||
| expect(body.rule_source.type).toEqual('external'); |
There was a problem hiding this comment.
Asserting the response of the PATCH endpoint is not enough. We should also fetch this rule and make sure it actually has the values of these fields, as stored in ES.
There was a problem hiding this comment.
Unfortunately I'm missing tests for:
- Base cases:
- Customizing rules via the PUT endpoint
- Customizing rules via bulk editing actions
- Reverting customizations via bulk editing actions
- Handling missing base versions
- Tests for ESQL rule fields
- Edge cases:
- Saving a rule with the same parameters (the test should verify that the rule shouldn't be marked as customized)
This is just from reviewing the PR changes at a high level. There may be more cases to cover. I'm going to review the rule customization test plan to figure this out.
banderror
approved these changes
Feb 24, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
elastic#207016) ## Summary Adds tests in accordance to elastic#204888 Adds integration tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919 - [x] 🟡 Serverless x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920 - [x] 🟡 Serverless x100 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927 --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a51e96e)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…n tests (#207016) (#212253) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Adds prebuilt rule customization integration tests (#207016)](#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
banderror
pushed a commit
that referenced
this pull request
Feb 24, 2025
…212170) **Partially addresses:** #202068 ## Summary Adds tests in accordance to #204888 Follow-up to #207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926 (cherry picked from commit ca6cc75)
This was referenced Feb 24, 2025
Merged
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dplumlee
added a commit
to dplumlee/kibana
that referenced
this pull request
Feb 24, 2025
elastic#207016) ## Summary Adds tests in accordance to elastic#204888 Adds integration tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919 - [x] 🟡 Serverless x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920 - [x] 🟡 Serverless x100 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927 --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a51e96e)
dplumlee
added a commit
that referenced
this pull request
Feb 25, 2025
…n tests (#207016) (#212313) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization integration tests (#207016)](#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212253","number":212253,"state":"MERGED","mergeCommit":{"sha":"c8beef4b9608465b14a097d8ab5fecb8fffbff5b","message":"[9.0] [Security Solution] Adds prebuilt rule customization integration tests (#207016) (#212253)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Adds prebuilt rule customization integration\ntests (#207016)](https://github.com/elastic/kibana/pull/207016)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Davis Plumlee <[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
dplumlee
added a commit
that referenced
this pull request
Feb 25, 2025
…on tests (#207016) (#212314) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Adds prebuilt rule customization integration tests (#207016)](#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212253","number":212253,"state":"MERGED","mergeCommit":{"sha":"c8beef4b9608465b14a097d8ab5fecb8fffbff5b","message":"[9.0] [Security Solution] Adds prebuilt rule customization integration tests (#207016) (#212253)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Adds prebuilt rule customization integration\ntests (#207016)](https://github.com/elastic/kibana/pull/207016)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Davis Plumlee <[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com//pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 25, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
elastic#207016) ## Summary Adds tests in accordance to elastic#204888 Adds integration tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919 - [x] 🟡 Serverless x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920 - [x] 🟡 Serverless x100 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927 --------- Co-authored-by: Elastic Machine <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
…lastic#212170) **Partially addresses:** elastic#202068 ## Summary Adds tests in accordance to elastic#204888 Follow-up to elastic#207016 Adds cypress tests for the prebuilt rule customization features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] 🟢 ESS x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7925 - [x] 🟢 Serverless x50: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7926
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…n tests (elastic#207016) (elastic#212313) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)](elastic#207016) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T14:35:17Z","message":"[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Adds prebuilt rule customization integration tests","number":207016,"url":"https://github.com/elastic/kibana/pull/207016","mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212253","number":212253,"state":"MERGED","mergeCommit":{"sha":"c8beef4b9608465b14a097d8ab5fecb8fffbff5b","message":"[9.0] [Security Solution] Adds prebuilt rule customization integration tests (elastic#207016) (elastic#212253)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Adds prebuilt rule customization integration\ntests (elastic#207016)](https://github.com/elastic/kibana/pull/207016)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Davis Plumlee <[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207016","number":207016,"mergeCommit":{"message":"[Security Solution] Adds prebuilt rule customization integration tests (elastic#207016)\n\n## Summary\n\nAdds tests in accordance to\nhttps://github.com/elastic/pull/204888\n\nAdds integration tests for the prebuilt rule customization features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] 🟢 ESS x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7919\n- [x] 🟡 Serverless x100:\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7920\n- [x] 🟡 Serverless x100\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7927\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"a51e96eae2904aa3488af1037d87d83beec2cd0d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests in accordance to #204888
Adds integration tests for the prebuilt rule customization features
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.