[ES|QL] Vertical align expand icon in history component #207042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
v9.0.0
Feature:ES|QL
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
vadimkibana
approved these changes
Jan 21, 2025
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 21, 2025
## Summary Closes elastic#204072 Aligns in top the expandable icon in the history component <img width="1675" alt="image" src="https://github.com/user-attachments/assets/0a2a98ae-759f-408e-9a30-dd0c7f884153" /> It also fixes a small bug. When the query was expanded and the user resized the window, the icon was vanished. (cherry picked from commit 4a6891f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 21, 2025
… (#207301) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Vertical align expand icon in history component (#207042)](#207042) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-21T09:10:47Z","message":"[ES|QL] Vertical align expand icon in history component (#207042)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/204072\r\n\r\nAligns in top the expandable icon in the history component\r\n\r\n<img width=\"1675\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0a2a98ae-759f-408e-9a30-dd0c7f884153\"\r\n/>\r\n\r\n\r\nIt also fixes a small bug. When the query was expanded and the user\r\nresized the window, the icon was vanished.","sha":"4a6891ff9f896d49a9eb6816e075cfdb0cfa17e7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0"],"title":"[ES|QL] Vertical align expand icon in history component","number":207042,"url":"https://github.com/elastic/kibana/pull/207042","mergeCommit":{"message":"[ES|QL] Vertical align expand icon in history component (#207042)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/204072\r\n\r\nAligns in top the expandable icon in the history component\r\n\r\n<img width=\"1675\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0a2a98ae-759f-408e-9a30-dd0c7f884153\"\r\n/>\r\n\r\n\r\nIt also fixes a small bug. When the query was expanded and the user\r\nresized the window, the icon was vanished.","sha":"4a6891ff9f896d49a9eb6816e075cfdb0cfa17e7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207042","number":207042,"mergeCommit":{"message":"[ES|QL] Vertical align expand icon in history component (#207042)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/204072\r\n\r\nAligns in top the expandable icon in the history component\r\n\r\n<img width=\"1675\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0a2a98ae-759f-408e-9a30-dd0c7f884153\"\r\n/>\r\n\r\n\r\nIt also fixes a small bug. When the query was expanded and the user\r\nresized the window, the icon was vanished.","sha":"4a6891ff9f896d49a9eb6816e075cfdb0cfa17e7"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 21, 2025
## Summary Closes elastic#204072 Aligns in top the expandable icon in the history component <img width="1675" alt="image" src="https://github.com/user-attachments/assets/0a2a98ae-759f-408e-9a30-dd0c7f884153" /> It also fixes a small bug. When the query was expanded and the user resized the window, the icon was vanished.
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary Closes elastic#204072 Aligns in top the expandable icon in the history component <img width="1675" alt="image" src="https://github.com/user-attachments/assets/0a2a98ae-759f-408e-9a30-dd0c7f884153" /> It also fixes a small bug. When the query was expanded and the user resized the window, the icon was vanished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #204072
Aligns in top the expandable icon in the history component
It also fixes a small bug. When the query was expanded and the user resized the window, the icon was vanished.