Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP] Revert postValidate isPublicAccess #207829

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[HTTP] Revert postValidate isPublicAccess #207829

merged 1 commit into from
Jan 22, 2025

Conversation

afharo
Copy link
Member

@afharo afharo commented Jan 22, 2025

Summary

Follow up to #199026
Related to #199616

When working on #199616, we noticed that we counted (and now logged) all the APIs serving http-resources (like the /bundles/ routes).

After discussing #207725 with the team, we went with reverting the calculation of isPublicAccess

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 22, 2025
@afharo afharo self-assigned this Jan 22, 2025
@afharo afharo requested a review from a team as a code owner January 22, 2025 14:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo mentioned this pull request Jan 22, 2025
Closed
jloleysens
jloleysens approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as a nit would you mind adding/updating the test in post validation events in route.test.ts to lock this down a bit?

@afharo afharo mentioned this pull request Jan 22, 2025
Merged
Bamieh
Bamieh approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo enabled auto-merge (squash) January 22, 2025 14:18
@afharo afharo added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 22, 2025
@afharo
Copy link
Member Author

afharo commented Jan 22, 2025

Changes backported in #207828

@afharo afharo merged commit cf4d79c into elastic:main Jan 22, 2025
19 checks passed
@afharo afharo deleted the http/revert-post-validate-ispublicaccess branch January 22, 2025 15:59
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / InsertTimeline should call useInsertTimeline with correct arguments

Metrics [docs]

✅ unchanged

cc @afharo

viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@afharo @viduni94
[HTTP] Revert postValidate isPublicAccess (elastic#207829)
3dc85e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@jloleysens jloleysens jloleysens approved these changes

Assignees

@afharo afharo

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afharo @elasticmachine @Bamieh @jloleysens @kibanamachine