[8.x] [Fleet] Fix wrong condition in status runtime (#211779) #211830
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ac63ee9) # Conflicts: # x-pack/platform/plugins/shared/fleet/server/services/agents/build_status_runtime_field.test.ts # x-pack/platform/plugins/shared/fleet/server/services/agents/build_status_runtime_field.ts
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
| @@ -70,7 +70,7 @@ const _buildInactiveCondition = (opts: { | |||
| }) | |||
| .join(' || '); | |||
|
|
|||
| return `lastCheckinMillis > 0 && ${field('policy_id')}.size() > 0 && ${policyClauses}`; | |||
| return `lastCheckinMillis > 0 && ${field('policy_id')}.size() > 0 && (${policyClauses})`; | |||
There was a problem hiding this comment.
@nchaulet is the condition intentionally different than in main? https://github.com/elastic/kibana/pull/211779/files#diff-254672ee94b69f9784dd494532cf311f4197dab080519d36cba0f0b4184fa8a5
There was a problem hiding this comment.
It is different as that backport PR is not merged yet #211764 I will update the PR when it's merged
juliaElastic
approved these changes
Feb 20, 2025
💚 Build Succeeded
Metrics [docs]
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation