Siem Migrations - Fix rules upload API Error Test. #212290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
logeekal
added
v9.0.0
backport:version
semd
approved these changes
Feb 24, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
💚 Build Succeeded
Metrics [docs]
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
## Summary This PR fixes a incorrect UI test : - Rules Upload File component should only display API Error in case it occurs, while previously the tests was check if the button is disabled or not. Disability of button is irrelevant. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 681cef4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 24, 2025
## Summary This PR fixes a incorrect UI test : - Rules Upload File component should only display API Error in case it occurs, while previously the tests was check if the button is disabled or not. Disability of button is irrelevant. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 681cef4)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…212300) # Backport This will backport the following commits from `main` to `8.18`: - [ Siem Migrations - Fix rules upload API Error Test. (#212290)](#212290) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:59:41Z","message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":" Siem Migrations - Fix rules upload API Error Test.","number":212290,"url":"https://github.com/elastic/kibana/pull/212290","mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212290","number":212290,"mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 25, 2025
## Summary This PR fixes a incorrect UI test : - Rules Upload File component should only display API Error in case it occurs, while previously the tests was check if the button is disabled or not. Disability of button is irrelevant. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
## Summary This PR fixes a incorrect UI test : - Rules Upload File component should only display API Error in case it occurs, while previously the tests was check if the button is disabled or not. Disability of button is irrelevant. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
logeekal
added a commit
to logeekal/kibana
that referenced
this pull request
Feb 28, 2025
## Summary This PR fixes a incorrect UI test : - Rules Upload File component should only display API Error in case it occurs, while previously the tests was check if the button is disabled or not. Disability of button is irrelevant. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 681cef4)
kibanamachine
added a commit
that referenced
this pull request
Feb 28, 2025
…212301) # Backport This will backport the following commits from `main` to `8.x`: - [ Siem Migrations - Fix rules upload API Error Test. (#212290)](#212290) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:59:41Z","message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":" Siem Migrations - Fix rules upload API Error Test.","number":212290,"url":"https://github.com/elastic/kibana/pull/212290","mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212290","number":212290,"mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
logeekal
added a commit
that referenced
this pull request
Feb 28, 2025
…212712) # Backport This will backport the following commits from `main` to `9.0`: - [ Siem Migrations - Fix rules upload API Error Test. (#212290)](#212290) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:59:41Z","message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","Team:Threat Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":" Siem Migrations - Fix rules upload API Error Test.","number":212290,"url":"https://github.com/elastic/kibana/pull/212290","mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212300","number":212300,"state":"MERGED","mergeCommit":{"sha":"797a695ae413cb28c52fe238432e9686cb218ad9","message":"[8.18] Siem Migrations - Fix rules upload API Error Test. (#212290) (#212300)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.18`:\n- [ Siem Migrations - Fix rules upload API Error Test.\n(#212290)](https://github.com/elastic/kibana/pull/212290)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Jatin Kathuria <[email protected]>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212290","number":212290,"mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212301","number":212301,"state":"OPEN"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
) (elastic#212301) # Backport This will backport the following commits from `main` to `8.x`: - [ Siem Migrations - Fix rules upload API Error Test. (elastic#212290)](elastic#212290) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-24T18:59:41Z","message":" Siem Migrations - Fix rules upload API Error Test. (elastic#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":" Siem Migrations - Fix rules upload API Error Test.","number":212290,"url":"https://github.com/elastic/kibana/pull/212290","mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (elastic#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212290","number":212290,"mergeCommit":{"message":" Siem Migrations - Fix rules upload API Error Test. (elastic#212290)\n\n## Summary\n\nThis PR fixes a incorrect UI test :\n\n- Rules Upload File component should only display API Error in case it\noccurs, while previously the tests was check if the button is disabled\nor not. Disability of button is irrelevant.\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"681cef4590e4847bdd1d6c9eaa68cd4f539e8cc2"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a incorrect UI test :
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.