-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UA] Facilitate batch reindex command to user #212365
base: 8.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong feeling on my comments. I figure we may want to add just a bit more context to the modal, maybe?
..._assistant/public/application/components/es_deprecations/bulk_reindex/bulk_reindex_modal.tsx
Outdated
Show resolved
Hide resolved
..._assistant/public/application/components/es_deprecations/bulk_reindex/bulk_reindex_modal.tsx
Outdated
Show resolved
Hide resolved
..._assistant/public/application/components/es_deprecations/bulk_reindex/bulk_reindex_modal.tsx
Show resolved
Hide resolved
..._assistant/public/application/components/es_deprecations/bulk_reindex/bulk_reindex_modal.tsx
Outdated
Show resolved
Hide resolved
Thanks for having a look @florent-leborgne! I've addressed your feedback with 8bfb87d |
Pinging @elastic/kibana-management (Team:Kibana Management) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on that @sabarasaba!! I've done some manual testing and I don't think we should allow users to select indices that are already reindexed or in progress, what do you think?
Screen.Recording.2025-02-27.at.15.18.10.mov
Apart from that, everything looks good to me. It has been so nice to reindex 34 indices with just 4 total clicks! 😻
That's a very good and valid point, thanks for bringing that up! I've fixed that with 770829b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let you a nitpick comment, but I tested locally and it looks good to me :)
...c/application/components/es_deprecations/deprecation_types/indices/resolution_table_cell.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @sabarasaba |
Summary
This PR adds support for bulk selecting ES deprecations and show a console command to reindex them.
How to test
Demo
Screen.Recording.2025-02-26.at.11.34.56.mov
Screenshots