Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Facilitate batch reindex command to user #212365

Open
wants to merge 20 commits into
base: 8.x
Choose a base branch
from

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Feb 25, 2025

Summary

This PR adds support for bulk selecting ES deprecations and show a console command to reindex them.

How to test

  • Follow the instructions in https://github.com/elastic/kibana-team/issues/1521. Use the data folder starting with [01] because it has the largest variety of deprecations.
  • Start kibana with the changes of this pr checked out
  • Verify that in UA -> ES Deprecations you can select multiple issues and if they are of the reindex type a CTA should appear that allows you to run the command in console.
Demo
Screen.Recording.2025-02-26.at.11.34.56.mov
Screenshots

Screenshot 2025-02-26 at 10 43 06

Screenshot 2025-02-26 at 10 43 11

Screenshot 2025-02-26 at 10 43 15

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant backport:version Backport to applied version labels v8.18.0 v8.19.0 labels Feb 25, 2025
@sabarasaba sabarasaba requested a review from a team February 25, 2025 12:40
@sabarasaba sabarasaba self-assigned this Feb 25, 2025
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feeling on my comments. I figure we may want to add just a bit more context to the modal, maybe?

@sabarasaba
Copy link
Member Author

Thanks for having a look @florent-leborgne! I've addressed your feedback with 8bfb87d

@sabarasaba sabarasaba changed the title [UA] bulk reindex command [UA] Facilitate batch reindex command to user Feb 26, 2025
@sabarasaba sabarasaba marked this pull request as ready for review February 26, 2025 15:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on that @sabarasaba!! I've done some manual testing and I don't think we should allow users to select indices that are already reindexed or in progress, what do you think?

Screen.Recording.2025-02-27.at.15.18.10.mov

Apart from that, everything looks good to me. It has been so nice to reindex 34 indices with just 4 total clicks! 😻

@sabarasaba
Copy link
Member Author

I've done some manual testing and I don't think we should allow users to select indices that are already reindexed or in progress, what do you think?

That's a very good and valid point, thanks for bringing that up! I've fixed that with 770829b

Screenshots

Screenshot 2025-02-28 at 15 44 07
Screenshot 2025-02-28 at 15 43 49

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you a nitpick comment, but I tested locally and it looks good to me :)

@sabarasaba sabarasaba removed the request for review from kibanamachine March 3, 2025 09:36
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
upgradeAssistant 194 197 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 208.7KB 217.1KB +8.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 23.8KB 23.8KB +26.0B

History

cc @sabarasaba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants