[UA] Make public APIs internal #214051
Merged
[UA] Make public APIs internal #214051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
release_note:breaking
Team:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
afharo
reviewed
Mar 12, 2025
.../plugins/private/upgrade_assistant/server/routes/reindex_data_streams/reindex_data_stream.ts
Show resolved
Hide resolved
afharo
approved these changes
Mar 13, 2025
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 9.0 |
💚 Build Succeeded
Metrics [docs]
History
cc @sabarasaba |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Mar 14, 2025
(cherry picked from commit b190747) # Conflicts: # x-pack/platform/plugins/private/upgrade_assistant/server/routes/reindex_data_streams/reindex_data_stream.ts # x-pack/platform/plugins/private/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
sabarasaba
added a commit
that referenced
this pull request
Mar 18, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[UA] Make public APIs internal (#214051)](#214051) [This](https://buildkiteartifacts.com/e0f3970e-3a75-4621-919f-e6c773e2bb12/0fda5127-f57f-42fb-8e5a-146b3d535916/019594b0-1482-4846-9843-39b20cd6c147/019594ce-e625-4572-9443-038ef0595665/target/test_failures/019594ce-e625-4572-9443-038ef0595665_4535fcc590c141c7ac8ba190ac3aa7fb.html?response-content-type=text%2Fhtml&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LTY4FRNQO%2F20250317%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20250317T075950Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEOb%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJGMEQCICvi%2Fi5ZNRe9khzAMUXgH5jMfLTujT4LYjYsdlTp0iBoAiBjwBmriSVFUYp1b%2FNGLcHXJe4Yb%2BebPTC%2FK20xJZvCdCrxAwg%2FEAAaDDAzMjM3OTcwNTMwMyIMNsNxl99WzzwsTnPoKs4Dry694zjFyRoy2uOJPWBFig%2BEki825QMOPQln1tRTkEfLnq5RrTFWy3OKcMQbvCi6pPXNKfOfjbofKw1xQwGVL%2BWx75P4vRQtqoIOhfnUB2yb3gSraOlM1cfCrMeTsWLx0xXuaSn2R3wDmVMyf6iEc8clvUKKjdYkyfFKJiUGB3CEpts6uNfYtetgp7QE0toeYunug8cZfEC5f8n%2B5ncwVAUuevo%2BleOyk4Gv3hwsdF48pNheos32P6SayINhwKv5OGtrOjYvG2BHxz4TWzDQoDBlqLTehDnpg%2Fmq0daHWtynB0GRRDn3cvdhhZdSCQcdogrVjeW19dJAAi5z%2BVTcVU0b7%2FOZ565ptU75axQKyNYOGICc%2BrnjboBBVUQzXgDGXemi%2BdPRX%2F4bJZ5igJfF%2FIpe0Nl%2BrqOROHNKlGh6xdHTU7rhXHvtMlH4wwXhenvG5tEL%2BOXoUuhrU6hqQZoXJ6tUm%2Fk7j5MO6ssbl%2FwVE4LwGmVlxJHA8eyW%2Fxv6b%2BmHqVnjBL8ScBnrVBoz3A5VRqTA7jGhgau0FWshGhzeaAMxovORBKDuQVcn7uAwEk78sLO961BD7r3jph0WwE0khC5Z3GihY00YBwSOAS4AML%2F23r4GOqYBXBr1XkZzPxJJDqRT9juGCiDKYelnayWstQq8gJqRWq1P04nEyGwKKdakbbvMZwlZKvU3pYdTV5dtmf4oUQBz3OMBbouYGVCvMW5Ie08UGbwodSfA8GpjrbyqSaok7OSW3rZ2wqPTU8bEg7iMea0ytOwNP9a2ENGibD46o5kseaSWohQ%2FrRsID5zC0A1NW8K38%2F1MC3keT2SxuoXp%2FMPPduFV5k5KtA%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=714d4b9a4a9fc7f98be4e96c086676552d463e44a0f042da1a18a7418975c48a) test was failing for this backport but not on main given that [it was skipped](#209048). Now that the routes are internal instead of public, they are generating additional counters. Fixing the test proved to be harder than expected so I've decided to skip the reindexing test for now in order to get this in asap. <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-14T09:14:27Z","message":"[UA] Make public APIs internal (#214051)","sha":"b190747260ec06e763ede631c16612bacca787b0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:breaking","Team:Kibana Management","Feature:Upgrade Assistant","v9.0.0","backport:version","v9.1.0"],"title":"[UA] Make public APIs internal","number":214051,"url":"https://github.com/elastic/kibana/pull/214051","mergeCommit":{"message":"[UA] Make public APIs internal (#214051)","sha":"b190747260ec06e763ede631c16612bacca787b0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214051","number":214051,"mergeCommit":{"message":"[UA] Make public APIs internal (#214051)","sha":"b190747260ec06e763ede631c16612bacca787b0"}}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
kibanamachine
removed
the
backport missing
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Mar 20, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/elastic/dev/issues/3059
Summary
This PR makes the Upgrade Assistant reindexing APIs (reindex and batch reindex) to be internal. These APIs were initially introduced for Kibana’s own reindexing needs but were always marked as experimental. By restricting their access, we ensure they are only used by the UI and encourage users to rely on Elasticsearch’s native reindexing APIs for programmatic reindexing.
Release note
Upgrade Assistant public APIs for reindexing and batch reindexing have been made internal. We encourage users to rely on Elasticsearch’s native reindexing APIs for programmatic reindexing.