Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UA] Exponential backoff strategy for reindexing worker #214326

Merged
merged 6 commits into from
Mar 18, 2025
Merged

[UA] Exponential backoff strategy for reindexing worker #214326

merged 6 commits into from
Mar 18, 2025

Conversation

sabarasaba
Copy link
Member

Partially addresses: #214076

Summary

  1. The worker now uses exponential backoff for updates, starting at 1 second and doubling with each iteration
  2. The maximum worker padding is dynamically calculated to be no more than 1/4 of the PAUSE_WINDOW (30 seconds)
  3. This guarantees at least 4 update attempts will happen before the PAUSE_WINDOW threshold is reached
  4. The padding resets when operations with credentials are found or when the worker is restarted

@sabarasaba sabarasaba self-assigned this Mar 13, 2025
@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant backport:version Backport to applied version labels v8.18.0 v8.19.0 labels Mar 13, 2025
@sabarasaba sabarasaba requested a review from a team March 14, 2025 07:47
@sabarasaba sabarasaba marked this pull request as ready for review March 14, 2025 07:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@sabarasaba sabarasaba requested review from jloleysens and removed request for kibanamachine March 14, 2025 07:48
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

Bamieh
Bamieh approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #72 / Cloud Security Posture GET /internal/cloud_security_posture/stats CSPM Compliance Dashboard Stats API should return CSPM benchmarks V2

Metrics [docs]

✅ unchanged

History

cc @sabarasaba

@SoniaSanzV SoniaSanzV requested review from SoniaSanzV and removed request for a team March 17, 2025 12:59
SoniaSanzV
SoniaSanzV approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@sabarasaba sabarasaba merged commit be2b9d3 into elastic:8.x Mar 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@SoniaSanzV SoniaSanzV SoniaSanzV approved these changes

@jloleysens jloleysens Awaiting requested review from jloleysens

Assignees

@sabarasaba sabarasaba

Labels
backport:version Backport to applied version labels Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v8.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sabarasaba @elasticmachine @Bamieh @SoniaSanzV @kibanamachine