Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix index templates api integration tests #214958

Merged

Conversation

ElenaStoeva
Copy link
Contributor

Fixes #209027

Summary

This PR updates the 8.x index templates API integration tests to fix the failures in the 8.x -> 9.0 forward compatibility tests.

To run the forward-compatibility tests locally:

ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.0.0/manifest-latest-verified.json" node scripts/functional_tests_server.js --config ./x-pack/test/api_integration/apis/management/config.ts

and

ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.0.0/manifest-latest-verified.json" node scripts/functional_test_runner.js --config ./x-pack/test/api_integration/apis/management/config.ts --grep="index templates"

@ElenaStoeva ElenaStoeva added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.18.0 v8.19.0 labels Mar 18, 2025
@ElenaStoeva ElenaStoeva self-assigned this Mar 18, 2025
@ElenaStoeva ElenaStoeva marked this pull request as ready for review March 18, 2025 11:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) March 18, 2025 12:40
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / notesSlice notesReducer fetchNotesByDocumentIds should replace notes when success on fetch notes by document ids on a non-empty state
  • [job] [logs] Jest Tests #5 / notesSlice notesReducer fetchNotesBySavedObjectIds should replace notes when success on fetch notes by saved object id ids on a non-empty state

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 753 754 +1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 779 780 +1

cc @ElenaStoeva

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @ElenaStoeva :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants