[UA] Change default reindex flyout action based on index size #215302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Team:Kibana Management
💔 Build Failed
Failed CI StepsHistory
cc @sabarasaba |
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
@elasticmachine merge upstream |
SoniaSanzV
approved these changes
Mar 21, 2025
| @@ -96,6 +97,13 @@ export const ReindexDetailsFlyoutStep: React.FunctionComponent<{ | |||
| showDefaultGuidance = true; | |||
| } | |||
|
|
|||
| // Determine if the index is larger than 1GB | |||
| const isLargeIndex = indexSizeInBytes > 1073741824; | |||
There was a problem hiding this comment.
Nit: for readability reasons, I would add 1073741824 to a constant to be able to compare const isLargeIndex = indexSizeInBytes > ONE_GB;
In any case, with the comment it is also clear.
There was a problem hiding this comment.
The thing is that if that value changes later we also need to rename the const. I think I'll leave as is for now 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #211730
Summary
This PR changes the default action for reindexing (mark as read only and reindex) based on the size of the index. When it's larger than 1gb we recommend marking as read only, otherwise reindex.
NOTE: I've also added a recommended badge that is shown on either
reindexormark as read onlybased on the index size.NOTE: This PR also changes the color of secondary action for the reindexing flyout. Where it used to be red (signaling some sort of danger) and now its been made into a lighter blue:
// before
// after
Screenshots
// Also for datastreams actions we change the CTA color from red to light blue
