Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Fixes broken maps link to Kibana index management #73757

Merged
merged 6 commits into from
Jul 30, 2020

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented Jul 29, 2020

Summary

Embarrassing simple fix

If you don't have an index setup like below and click configure index patterns it takes you to /app/kibana when it should just be /app and there shouldn't be anymore hashes of #.

Screen Shot 2020-07-29 at 5 09 10 PM

@FrankHassanabad FrankHassanabad requested review from a team as code owners July 29, 2020 23:07
@FrankHassanabad FrankHassanabad self-assigned this Jul 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@FrankHassanabad FrankHassanabad changed the title [SIEM] Fixes broken maps link to Kibana [SIEM] Fixes broken maps link to Kibana index mangement Jul 29, 2020
@FrankHassanabad FrankHassanabad changed the title [SIEM] Fixes broken maps link to Kibana index mangement [SIEM] Fixes broken maps link to Kibana index management Jul 29, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 30, 2020

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/security_solution/public/network/components/embeddables.IndexPatternsMissingPrompt renders correctly against snapshot

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `IndexPatternsMissingPrompt renders correctly against snapshot 1`

- Snapshot  - 2
+ Received  + 2

@@ -1,11 +1,11 @@
  <EuiEmptyPrompt
    actions={
      <EuiButton
        color="primary"
        fill={true}
-       href="/test/base/path/app/kibana#/management/kibana/indexPatterns"
+       href="/test/base/path/app/management/kibana/indexPatterns"
        target="_blank"
      >
        Configure index patterns
      </EuiButton>
    }
@@ -23,11 +23,11 @@
                  target="_blank"
                >
                  beats
                </a>,
                "defaultIndex": <a
-                 href="/test/base/path/app/kibana#/management/kibana/settings"
+                 href="/test/base/path/app/management/kibana/settings"
                  rel="noopener noreferrer"
                  target="_blank"
                >
                  securitySolution:defaultIndex
                </a>,
    at Object.test (/dev/shm/workspace/kibana/x-pack/plugins/security_solution/public/network/components/embeddables/index_patterns_missing_prompt.test.tsx:17:21)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusTest (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:205:40)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -9.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch and quick fix @FrankHassanabad -- thank you!

I was looking to see if there was a constant we could use for this, but doesn't look like there's one available at the moment (unless we can get access to the SO ui settings?). Would be nice to use a reference from Kibana core so we don't have to keep updating as routes change.

@FrankHassanabad FrankHassanabad merged commit 15f4ead into elastic:master Jul 30, 2020
@FrankHassanabad FrankHassanabad deleted the fix-broken-maps-link branch July 30, 2020 17:39
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this pull request Jul 30, 2020
## Summary

Embarrassing simple fix 

If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`.

<img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this pull request Jul 30, 2020
## Summary

Embarrassing simple fix 

If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`.

<img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
FrankHassanabad added a commit that referenced this pull request Jul 30, 2020
…3847)

## Summary

Embarrassing simple fix 

If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`.

<img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
FrankHassanabad added a commit that referenced this pull request Jul 30, 2020
…3846)

## Summary

Embarrassing simple fix 

If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`.

<img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jbudz jbudz removed the v9.0.0 label Sep 20, 2024
@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants