-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Fixes broken maps link to Kibana index management #73757
[SIEM] Fixes broken maps link to Kibana index management #73757
Conversation
…aved objects for cypress hill
Pinging @elastic/siem (Team:SIEM) |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/security_solution/public/network/components/embeddables.IndexPatternsMissingPrompt renders correctly against snapshotStandard Out
Stack Trace
Build metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice catch and quick fix @FrankHassanabad -- thank you!
I was looking to see if there was a constant we could use for this, but doesn't look like there's one available at the moment (unless we can get access to the SO ui settings?). Would be nice to use a reference from Kibana core so we don't have to keep updating as routes change.
## Summary Embarrassing simple fix If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`. <img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
## Summary Embarrassing simple fix If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`. <img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
…3847) ## Summary Embarrassing simple fix If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`. <img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
…3846) ## Summary Embarrassing simple fix If you don't have an index setup like below and click configure index patterns it takes you to `/app/kibana` when it should just be `/app` and there shouldn't be anymore hashes of `#`. <img width="1487" alt="Screen Shot 2020-07-29 at 5 09 10 PM" src="https://user-images.githubusercontent.com/1151048/88862759-4b90e580-d1be-11ea-834c-aedc73cc330a.png">
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Embarrassing simple fix
If you don't have an index setup like below and click configure index patterns it takes you to
/app/kibana
when it should just be/app
and there shouldn't be anymore hashes of#
.