Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build and publish custom Elastic images #18

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

rogercoll
Copy link
Collaborator

@rogercoll rogercoll commented Jun 3, 2024

Changes

Adds a GitHub action to publish our custom services images. The action will be triggered on each release. The workflow files are a copy of the upstream repository but pointing to the Elastic's dockerfiles and removing Dockerhub registry. Initially, we would be publishing the images to the repository Github image registry.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@rogercoll rogercoll force-pushed the build_elastic_images branch from 0033a92 to 0baf4a6 Compare June 5, 2024 09:07
@elastic-apm-tech elastic-apm-tech force-pushed the main branch 6 times, most recently from bb22d3e to 4b42c76 Compare June 10, 2024 18:30
@rogercoll rogercoll force-pushed the build_elastic_images branch from 0baf4a6 to 1dfebfe Compare June 12, 2024 12:25
@rogercoll rogercoll marked this pull request as ready for review June 12, 2024 12:32
@rogercoll rogercoll force-pushed the build_elastic_images branch 2 times, most recently from cf8ca69 to 11466ba Compare June 13, 2024 13:09
@rogercoll rogercoll requested review from ChrsMark June 13, 2024 13:11
@elastic-apm-tech elastic-apm-tech force-pushed the main branch 2 times, most recently from 4eea166 to 4d841ca Compare June 14, 2024 06:30
@rogercoll rogercoll force-pushed the build_elastic_images branch from 11466ba to 34293c8 Compare June 18, 2024 07:10
@rogercoll rogercoll requested a review from a team June 18, 2024 08:12
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogercoll rogercoll merged commit 189843f into elastic:main Jun 18, 2024
2 of 3 checks passed
elastic-apm-tech pushed a commit that referenced this pull request Jun 18, 2024
* ci: build and publish custom Elastic images

* ci: use Elastic Dockerfile for adservice

* ci: add release file

* ci: remove on push trigger

* ci: add workflow to test image generation on push
elastic-apm-tech pushed a commit that referenced this pull request Jun 18, 2024
* ci: build and publish custom Elastic images

* ci: use Elastic Dockerfile for adservice

* ci: add release file

* ci: remove on push trigger

* ci: add workflow to test image generation on push
elastic-apm-tech pushed a commit that referenced this pull request Jun 19, 2024
* ci: build and publish custom Elastic images

* ci: use Elastic Dockerfile for adservice

* ci: add release file

* ci: remove on push trigger

* ci: add workflow to test image generation on push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants