Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates phrasing when referring to pages #2864

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Oct 31, 2024

Overview

This PR updates app and page references to align with the new style guide guidelines, ensuring consistency across both the classic and solution views to help users locate pages regardless of their chosen view. Additionally, the update removes interactive checkboxes, replacing them with bullet points.

Related issue

https://github.com/elastic/search-docs-team/issues/205

@kosabogi kosabogi added v8.16 backport-8.16 Automated backport with mergify labels Oct 31, 2024
@kosabogi kosabogi requested a review from a team as a code owner October 31, 2024 12:17
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kosabogi kosabogi marked this pull request as draft October 31, 2024 12:17
@kosabogi kosabogi marked this pull request as ready for review November 4, 2024 06:29
Copy link

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this @kosabogi. We should be using "global search field" instead of "global search bar". Otherwise LGTM

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosabogi kosabogi merged commit d015f34 into elastic:main Nov 6, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
* Updates phrasing when referring to pages

* Fixes typos

* Replaces 'global search bar' with 'global search field'

(cherry picked from commit d015f34)

# Conflicts:
#	docs/en/stack/ml/anomaly-detection/ml-detect-categories.asciidoc
#	docs/en/stack/ml/anomaly-detection/ml-population-analysis.asciidoc
kosabogi added a commit that referenced this pull request Nov 25, 2024
* Updates phrasing when referring to pages (#2864)

* Updates phrasing when referring to pages

* Fixes typos

* Replaces 'global search bar' with 'global search field'

(cherry picked from commit d015f34)

# Conflicts:
#	docs/en/stack/ml/anomaly-detection/ml-detect-categories.asciidoc
#	docs/en/stack/ml/anomaly-detection/ml-population-analysis.asciidoc

* Resolves merge conflict

---------

Co-authored-by: kosabogi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.16 Automated backport with mergify v8.16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants