-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grafana datasources and tests for multi wc #2314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
9fb51c6
to
ec1ffcd
Compare
.should("exist") | ||
cy.yqDigParse("sc", ".global.clustersMonitoring") | ||
.then(([first_cluster, ...rest_clusters]) => { | ||
cy.contains(`Workload Cluster ${first_cluster}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test working now? Doesn't this also need a check if it only is one WC or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, thought I tested but think i had the wrong naming still then. Fixed now, for some reason I also had to revert my change that added parent()
. I tested this with both single and multi wc.
ec1ffcd
to
1344609
Compare
556de7a
to
30bf321
Compare
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
What does this PR do / why do we need this PR?
Makes sure there is always a default datasource in grafana even with multiple WCs.
Fixes grafana datasource test to include all wc datasources.
Information to reviewers
Checklist
NetworkPolicy Dashboard