Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Change default for external traffic policy to local #2317

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Xartos
Copy link
Contributor

@Xartos Xartos commented Oct 18, 2024

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

Release notes

Default external traffic policy is now set to local. If your infrastructure doesn't support this, please set .externalTrafficPolicy.local to false.

Platform Administrator notice

Default external traffic policy is now set to local. If your infrastructure doesn't support this, please set .externalTrafficPolicy.local to false.

What does this PR do / why do we need this PR?

...

  • Fixes #

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change upgrades CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@linus-astrom
Copy link
Contributor

Did you miss making the change in this file? Or did you leave it as is on purpose?

@robinelastisys robinelastisys requested review from robinelastisys and removed request for robinelastisys October 18, 2024 10:56
@Xartos
Copy link
Contributor Author

Xartos commented Oct 18, 2024

Did you miss making the change in this file? Or did you leave it as is on purpose?

I assume that this is required to run the local cluster, but to be honest I didn't check.
I'll see if this is the case

@Xartos Xartos force-pushed the fli/default-to-ext-trfc-plcy-false branch from baccbcf to b4809a7 Compare October 31, 2024 14:25
@Xartos Xartos merged commit b4809a7 into main Oct 31, 2024
12 checks passed
@Xartos Xartos deleted the fli/default-to-ext-trfc-plcy-false branch October 31, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants