config: fix HNC config templating

[OlleLarsson]

Warning

This is a public repository, ensure not to disclose:

• personal data beyond what is necessary for interacting with this pull request, nor
• business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

• kind/feature
• kind/improvement
• kind/deprecation
• kind/documentation
• kind/clean-up
• kind/bug
• kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

• kind/admin-change
• kind/dev-change
• kind/security
• kind/adr

What does this PR do / why do we need this PR?

Now unpropagatedAnnotations and managedNamespaceAnnotations can be specified as lists as originally intended.

...

Information to reviewers

Values set

hnc:
  managedNamespaceAnnotations:
    - asd
    - hej

Before:

+             - --managed-namespace-annotation=asd hej

Now:

+             - --managed-namespace-annotation=asd
+             - --managed-namespace-annotation=hej

Checklist

• Proper commit message prefix on all commits
• Change checks:
  • The change is transparent
  • The change is disruptive
  • The change requires no migration steps
  • The change requires migration steps
  • The change upgrades CRDs
  • The change updates the config and the schema
• Documentation checks:
  • The public documentation required no updates
  • The public documentation required an update - [link to change](set-me)
• Metrics checks:
  • The metrics are still exposed and present in Grafana after the change
  • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
  • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
• Logs checks:
  • The logs do not show any errors after the change
• Pod Security Policy checks:
  • Any changed pod is covered by Pod Security Admission
  • Any changed pod is covered by Gatekeeper Pod Security Policies
  • The change does not cause any pods to be blocked by Pod Security Admission or Policies
• Network Policy checks:
  • Any changed pod is covered by Network Policies
  • The change does not cause any dropped packets in the NetworkPolicy Dashboard
• Audit checks:
  • The change does not cause any unnecessary Kubernetes audit events
  • The change requires changes to Kubernetes audit policy
• Falco checks:
  • The change does not cause any alerts to be generated by Falco
• Bug checks:
  • The bug fix is covered by regression tests

[robinAwallace]

Would it be possible to add a test for this? @simonklb you maybe know how and where to add it?

[simonklb]

Would it be possible to add a test for this? @simonklb you maybe know how and where to add it?

Yes! I don't think we have any tests that does this currently but it would be nice to introduce tests that verifies that our config renders the expected manifests.

You could probably take inspiration from

compliantkubernetes-apps/tests/unit/general/chart-lint.bats

Line 29 in e9a679f

@test "charts should follow linter - service cluster" {

[OlleLarsson]

Would it be possible to add a test for this? @simonklb you maybe know how and where to add it?

Yes! I don't think we have any tests that does this currently but it would be nice to introduce tests that verifies that our config renders the expected manifests.

You could probably take inspiration from

compliantkubernetes-apps/tests/unit/general/chart-lint.bats

Line 29 in e9a679f

@test "charts should follow linter - service cluster" {

Do you think that I should try to find the time to add tests for this?
I'm not too familiar with bats and I'm therefore a bit unsure of how big of a task it would be to add the tests 😅

[simonklb]

Would it be possible to add a test for this? @simonklb you maybe know how and where to add it?

Yes! I don't think we have any tests that does this currently but it would be nice to introduce tests that verifies that our config renders the expected manifests.
You could probably take inspiration from

compliantkubernetes-apps/tests/unit/general/chart-lint.bats

Line 29 in e9a679f

@test "charts should follow linter - service cluster" {

Do you think that I should try to find the time to add tests for this? I'm not too familiar with bats and I'm therefore a bit unsure of how big of a task it would be to add the tests 😅

Completely up to you! It brings up a good question though, maybe we should add one or two extra story points for testing purposes. @elastisys/scrum-masters ?